generate base on 1.34 #1654
generate base on 1.34 #1654
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
* fix: update file references and clean up validation comments in models * chore: add symlink to CONTRIBUTING.md for easier access * fix: update documentation to include full type names for WebSocket and Predicate * fix: include CONTRIBUTING.md in docfx.json build content
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
do-not-merge/work-in-progress
…rmalization in generator context
…ibility and improvements
…g package versions for compatibility
…rmalization in generator context
…ibility and improvements
…g package versions for compatibility
…versions for compatibility
…ibility and improvements
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Kubernetes client library to version 1.34, incrementing from 18.0 and removing the IBasicKubernetes interface in favor of direct IKubernetes inheritance.
- Version bump from 17.0 to 18.0 with Kubernetes 1.34 support
- Removal of
IBasicKubernetesinterface and direct inheritance fromIKubernetes - Addition of .NET 9.0 conditional compilation for X509 certificate loading improvements
- Code formatting improvements for better IDE source view through syntax tree normalization
Reviewed Changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.json | Version bump from 17.0 to 18.0 |
| csharp.settings | Kubernetes branch updated to v1.34.0 |
| README.md | Added version 18.0 compatibility table entry |
| Directory.Packages.props | Updated package dependencies to latest versions |
| src/KubernetesClient/IKubernetes.cs | Removed IBasicKubernetes inheritance |
| src/LibKubernetesGenerator/ | Template and generator updates for IKubernetes interface changes |
| tests/ | Added .NET 9.0 conditional compilation for X509CertificateLoader |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| private readonly HashSet<string> opblackList = | ||
| [ | ||
| "listClusterCustomObject", | ||
| "listNamespacedCustomObject", | ||
| }; | ||
| "listCustomObjectForAllNamespaces", | ||
| ]; |
There was a problem hiding this comment.
The variable name opblackList uses outdated terminology. Consider renaming to operationBlockList or excludedOperations to use more inclusive language.
Copilot uses AI. Check for mistakes.
IBasicKubernetesremoved