Skip to content

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Sep 9, 2025

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 9, 2025
@tg123 tg123 requested a review from Copilot September 10, 2025 09:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This refactor reorganizes Kubernetes client model interfaces by moving them from the root namespace to a dedicated Models subfolder and updating the namespace from k8s to k8s.Models.

  • Moved interface files (IStatus, ISpec, IMetadata, IItems) from root to Models folder
  • Updated namespace from k8s to k8s.Models for better organization
  • Updated project file references to reflect new file locations

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/KubernetesClient/Models/IStatus.cs Updated namespace from k8s to k8s.Models
src/KubernetesClient/Models/ISpec.cs Moved interface to Models folder with updated namespace
src/KubernetesClient/Models/IMetadata.cs Moved interface to Models folder with updated namespace
src/KubernetesClient/Models/IItems.cs Moved interface to Models folder with updated namespace
src/KubernetesClient/ISpec.cs Removed original file
src/KubernetesClient/IMetadata.cs Removed original file
src/KubernetesClient/IItems.cs Removed original file
src/KubernetesClient.Classic/KubernetesClient.Classic.csproj Updated file references to new Models folder paths
src/KubernetesClient.Aot/KubernetesClient.Aot.csproj Updated file references to new Models folder paths
examples/clientset/Program.cs Added using directive for k8s.Models namespace

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants