-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.1 #63
Release 0.1 #63
Conversation
Do we need to update the client capabilities badge? |
So there are commits that cancel out changes from the previous commit? I see a lot of change 1.0-SNAPSHOT to 0.1-SNAPSHOT in one commit, then 0.1-SNAPSHOT to 0.1 in another commit then 0.1 to 0.2-SNAPSHOT in another one. Why is that? We probably need to create a release branch if we need those intermediate commits for the release process. And yes, we can update client badge if we meet requirements for the next level. |
The release branch has already been created: https://github.com/kubernetes-client/java/tree/release-0.1 (and is pointing at the next snapshot release). The fact that our snapshot dependencies were sitting at 1.0 was incorrect. For the maven-release-plugin to publish the artifacts at version 0.1 they need to be checked it at version 0.1-SNAPSHOT - the plugin then automatically checked in a commit at version 0.1, released that, and revved the version to 0.2-SNAPSHOT. Further development against master is under the assumption that we will either release 0.2 or 1.0 next. Patch changes are made against the branch I linked to above. |
I see, it didn't realize those two PRs were created by the maven-release-plugin.
completely missed this line :) This looks good to me. |
NP - thanks! The 0.1 release is complete :) |
Nice. Thanks. Can you announce it on kubernetes dev mailing list? |
My email should have gone out about an hour ago - kubernetes-dev @ googlegroups? |
I saw it. The artifact ID is client-java-util? That is strange. I expected
client-java.
…On Aug 11, 2017 4:57 PM, "Lars Wander" ***@***.***> wrote:
My email should have gone out about an hour ago - kubernetes-dev @
googlegroups?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABic4GjG-kEDrnltEJ7fC7JRXSVDH8Nuks5sXOpggaJpZM4O0xm8>
.
|
Let's fix that with the next release |
Sorry for the churn, there were a few things left to fix
Non [maven-release-plugin] commits were written by me to get the release to pass.
Sonatypes validation of our artifacts has passed, I just need to update the JIRA ticket to indicate we've done our first release and the artifacts should be available after that.