fix: apply http agent if needed #2351
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
mstruebing
force-pushed
the
max/http-agent
branch
from
c992781 to
c8114fd
Compare
k8s-ci-robot
added
size/S
|
Code LGTM. Should we give @AmazingTurtle a chance to test before landing? |
src/config.ts
Outdated
| @@ -544,6 +545,8 @@ export class KubeConfig implements SecurityAuthentication { | |||
| } else { | |||
| throw new Error('Unsupported proxy type'); | |||
| } | |||
| } else if (cluster?.server?.startsWith('http:')) { | |||
There was a problem hiding this comment.
Can we also check for skipTlsVerify being true before we allow http URLs? It's really not secure to do this.
There was a problem hiding this comment.
Pushed a commit to check for skipTlsVerify as well and added a test for this.
I agree that it's not secure but I think the library should allow this as it is possible to do. 🤔
k8s-ci-robot
added
size/M
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This applies an http agent if needed.
I'm not entirely sure about the security implications of this, but I guess it should be not a problem though.
Fixes #2348