Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to examples/yaml_dir/nginx-deployment. #2360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rudra990
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR improves the Nginx deployment by:

Increasing replicas from 3 to 5 for better load balancing and availability.
Updating the Nginx image from 1.15.4 to 1.23.3, ensuring better security, performance, and fewer bugs.
Adding a Liveness Probe to automatically restart the app if it crashes.
Adding a Readiness Probe to ensure the app is fully ready before receiving traffic.
Setting Resource Limits to control CPU and RAM usage, preventing excessive resource consumption.
Introducing Environment Variables for dynamic configuration, allowing settings like WELCOME_MESSAGE to be customized easily.
Which issue(s) this PR fixes:
Fixes # (Add the issue number or link)

Special notes for your reviewer:
This PR enhances stability and performance for Nginx deployments in Kubernetes.
Please verify the updated image version and probe configurations.

ALSO, I am an individual contributor.
Thanks & Regards
Rudra

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 22, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 22, 2025
Copy link

linux-foundation-easycla bot commented Feb 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Rudra990 / name: Rudra (2e792cd)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 22, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Rudra990!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 22, 2025
@roycaihw
Copy link
Member

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented Mar 5, 2025

/retest

@yliaog
Copy link
Contributor

yliaog commented Mar 5, 2025

close the pr and reopen to trigger running tests

/close

@k8s-ci-robot
Copy link
Contributor

@yliaog: Closed this PR.

In response to this:

close the pr and reopen to trigger running tests

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yliaog
Copy link
Contributor

yliaog commented Mar 5, 2025

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

@yliaog: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rudra990
Once this PR has been reviewed and has the lgtm label, please ask for approval from yliaog. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants