-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to examples/yaml_dir/nginx-deployment. #2360
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @Rudra990! |
/assign @yliaog |
/retest |
close the pr and reopen to trigger running tests /close |
@yliaog: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@yliaog: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rudra990 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR improves the Nginx deployment by:
Increasing replicas from 3 to 5 for better load balancing and availability.
Updating the Nginx image from 1.15.4 to 1.23.3, ensuring better security, performance, and fewer bugs.
Adding a Liveness Probe to automatically restart the app if it crashes.
Adding a Readiness Probe to ensure the app is fully ready before receiving traffic.
Setting Resource Limits to control CPU and RAM usage, preventing excessive resource consumption.
Introducing Environment Variables for dynamic configuration, allowing settings like WELCOME_MESSAGE to be customized easily.
Which issue(s) this PR fixes:
Fixes # (Add the issue number or link)
Special notes for your reviewer:
This PR enhances stability and performance for Nginx deployments in Kubernetes.
Please verify the updated image version and probe configurations.
ALSO, I am an individual contributor.
Thanks & Regards
Rudra