Skip to content

fix: Drop host: localhost in probes to better fulfill PSA #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mkilchhofer wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: Drop host: localhost in probes to better fulfill PSA #1037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified charts/latest/csi-driver-nfs-v0.0.0.tgz
View file
Open in desktop
Binary file not shown.
3 changes: 1 addition & 2 deletions charts/latest/csi-driver-nfs/templates/csi-nfs-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ spec:
args:
- --csi-address=/csi/csi.sock
- --probe-timeout=3s
- --http-endpoint=localhost:{{ .Values.controller.livenessProbe.healthPort }}
- --http-endpoint=127.0.0.1:{{ .Values.controller.livenessProbe.healthPort }}
- --v=2
imagePullPolicy: {{ .Values.image.livenessProbe.pullPolicy }}
volumeMounts:
Expand Down Expand Up @@ -194,7 +194,6 @@ spec:
livenessProbe:
failureThreshold: 5
httpGet:
host: localhost
path: /healthz
port: {{ .Values.controller.livenessProbe.healthPort }}
initialDelaySeconds: 30
Expand Down
6 changes: 2 additions & 4 deletions charts/latest/csi-driver-nfs/templates/csi-nfs-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
args:
- --csi-address=/csi/csi.sock
- --probe-timeout=3s
- --http-endpoint=localhost:{{ .Values.node.livenessProbe.healthPort }}
- --http-endpoint=127.0.0.1:{{ .Values.node.livenessProbe.healthPort }}
- --v=2
imagePullPolicy: {{ .Values.image.livenessProbe.pullPolicy }}
volumeMounts:
Expand All @@ -75,7 +75,7 @@ spec:
- --csi-address=/csi/csi.sock
- --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
{{- if .Values.nodeDriverRegistrar.livenessProbe.enabled }}
- --http-endpoint=localhost:{{ .Values.nodeDriverRegistrar.healthPort }}
- --http-endpoint=127.0.0.1:{{ .Values.nodeDriverRegistrar.healthPort }}
{{- end }}
env:
- name: DRIVER_REG_SOCK_PATH
Expand All @@ -97,7 +97,6 @@ spec:
protocol: TCP
livenessProbe:
httpGet:
host: localhost
path: /healthz
port: healthz
initialDelaySeconds: {{ .Values.nodeDriverRegistrar.livenessProbe.initialDelaySeconds }}
Expand Down Expand Up @@ -139,7 +138,6 @@ spec:
livenessProbe:
failureThreshold: 5
httpGet:
host: localhost
path: /healthz
port: {{ .Values.node.livenessProbe.healthPort }}
initialDelaySeconds: 30
Expand Down