Skip to content

Conversation

@hswong3i
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR convert our static deployment manifests from deploy/kubernetes/* into Helm Charts under charts/*, by running a convert script under deploy/util/chart-releaser.sh.

Moreover, it handle the chart release with branch gh-pages, by integrate with https://github.com/helm/chart-releaser-action.

The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-external-snapshotter/index.yaml, by:

helm repo add external-snapshotter https://alvistack.github.io/kubernetes-csi-external-snapshotter
helm repo update
helm search repo external-snapshotter

Before each stable tag release, maintainers only required to:

  1. Run the ./deploy/util/chart-releaser.sh and update templates under charts/*/templates/*
  2. Double confirm charts/*/values.yml with correct values, e.g. image tags
  3. git add --all --force charts/* && git commit

Which issue(s) this PR fixes:
Fixes #551
Fixes #622
Fixes #751

Create Helm Chart from Static Manifests

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from gnufied August 27, 2025 08:26
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from humblec August 27, 2025 08:26
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hswong3i
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @hswong3i. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 27, 2025
@hswong3i
Copy link
Author

Sorry @TerryHowe may we continuous the review for #1285 with this new PR?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2025
@SkalaNetworks
Copy link

I'm sure there's a lot of value in getting this in a Helm Chart

@hswong3i hswong3i force-pushed the master branch 3 times, most recently from 971c24b to f8c31ee Compare December 5, 2025 13:10
@@ -0,0 +1,73 @@
#!/usr/bin/env bash

# Copyright 2025 The Kubernetes Authors.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in another PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in another PR

Which PR?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is generally preferred to have one change to one PR and this change is not related.

It is like going to the store to buy mangos and you have to take a pound of hamburger with it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to my original statement:

Before each stable tag release, maintainers only required to:

  • Run the ./deploy/util/chart-releaser.sh and update templates under charts/*/templates/
  • Double confirm charts/*/values.yml with correct values, e.g. image tags
  • git add --all --force charts/* && git commit

This PR is target to simplify workload for our developers, where the Chart could automatically release with GitHub Action.

Without the changes to deploy/util/chart-releaser.sh, this PR will become half made...

**What type of PR is this?**
/kind feature

**What this PR does / why we need it**:
This PR convert our static deployment manifests from `deploy/kubernetes/*` into Helm Charts under `charts/*`, by running a convert script under `deploy/util/chart-releaser.sh`.

Moreover, it handle the chart release with branch `gh-pages`, by integrate with https://github.com/helm/chart-releaser-action.

The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-external-snapshotter/index.yaml, by:

    helm repo add external-snapshotter https://alvistack.github.io/kubernetes-csi-external-snapshotter
    helm repo update
    helm search repo external-snapshotter

Before each stable tag release, maintainers only required to:
1. Run the `./deploy/util/chart-releaser.sh` and update templates under `charts/*/templates/*`
2. Double confirm `charts/*/values.yml` with correct values, e.g. image tags
3. `git add --all --force charts/* && git commit`

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@hswong3i hswong3i changed the title [v8.3.0] Create Helm Chart from Static Manifests [v8.4.0] Create Helm Chart from Static Manifests Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart for CRDs and snapshot controller?

5 participants