-
Notifications
You must be signed in to change notification settings - Fork 109
Change default probe timeout to 3 seconds #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Welcome @sathieu! |
Hi @sathieu. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
See issue 293
b6dcf49
to
518789f
Compare
Can someone review this PR? @jsafrane, @andyzhangx, others? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andyzhangx, sathieu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
The default probe timeout looks to low, and is increased in a lot of places as shown here and here. azure-lustre up to 120s!
I proposed to increase it in vsphere-csi-driver.
A better approach is to change the default, i.e. this PR
Which issue(s) this PR fixes:
Fixes #293
Special notes for your reviewer:
Is this a breaking change?
Does this PR introduce a user-facing change?: