-
Notifications
You must be signed in to change notification settings - Fork 630
🐛 fix: use cluster tag key to list managed egress-only internet gateway #5684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @tthvo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, overall looks good to me
/lgtm
LGTM label has been added. Git tree hash: 937d0731f74bddb1b97cd0b108f5b27d45da1255
|
/ok-to-test |
The API for DescribeEgressOnlyInternetGateways does not support attachment.vpc-id filter. Thus, the call will return all available eigw. Consequences: - CAPA incorrectly selects an unintended eigw for use. Leading to route creation failure since the eigw belongs to a different VPC. - CAPA incorrectly destroys all eigw of all VPCs. This is very catastrophic as it can break other workloads. This commit changes the filter to use cluster tag instead. Additional safeguard is also included to check if the eigw is truly attached the VPC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this. Looks potentially unpleasant.
/lgtm
/assign @richardcase @nrb @dlipovetsky @AndiDog
LGTM label has been added. Git tree hash: 69ea166237b93d8c0b3b5664b38f7806c786372a
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndiDog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-2.9 |
@damdo: new pull request created: #5694 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The API for
DescribeEgressOnlyInternetGateways
does not supportattachment.vpc-id
filter. Thus, the call will return all available eigw. Consequences:This changes the filter to use cluster tag instead. Additional safeguard is also included to check if the eigw is truly attached the VPC.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5683
Special notes for your reviewer:
This is a cherry-pick from c4dff2a as part of PR: #5603 (self-managed IPv6 cluster is in progress)
Checklist:
Release note: