-
Notifications
You must be signed in to change notification settings - Fork 629
WIP: 🌱 ClusterAPI v1.11 v1beta2 #5687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @toby-archer-tr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for this @toby-archer-tr . We have #5624 that has started this. |
Lets discuss on slack. Feel free to ping me. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Taking a stab at refactoring cluster-api-aws v1beta2 resources, based on the new v1.11+ v1beta2 cluster-api resources, along with following API contract changes around status' and the use of k8s conditions.
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer:
+k8s:conversion-gen=false
and attempting to wire in a custom conversion; however theconversion-gen
is proving a little tricky. My first approach was to provide a conversion for the v1alpha1.Condition -> metav1.Condition but as both packages are external, this doesn't work. I have not found any example or guidance on this, so far.Ready
, introduction of*InitializationStatus
and the uses of those in the controllers are correct.Checklist:
Release note:
TBD...