Skip to content

WIP: run gke e2e on pr ci #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: run gke e2e on pr ci #1445

wants to merge 1 commit into from

Conversation

salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Mar 17, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

GKE E2E are not running on new PRs. Let's modify the ginkgo filter to run managed cluster tests and verify if existing templates pass CI checks with the current configuration.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@salasberryfin
run gke e2e on pr ci
d0de097 
Signed-off-by: Carlos Salas <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@salasberryfin: The label(s) kind/other cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind other

What this PR does / why we need it:

GKE E2E are not running on new PRs. Let's modify the ginkgo filter to run managed cluster tests and verify if existing templates pass CI checks with the current configuration.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: salasberryfin
Once this PR has been reviewed and has the lgtm label, please assign richardcase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 17, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit d0de097
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/67d822252845310008bdcb61
😎 Deploy Preview https://deploy-preview-1445--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salasberryfin
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 17, 2025
@richardcase
Copy link
Member

Sounds like a great idea @salasberryfin

barbacbd
barbacbd reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salasberryfin Looks like the CI failure is not directly related to this PR. We could probably override and fix the failure in another PR. WDYT?

@salasberryfin
Copy link
Contributor Author

@barbacbd I was thinking about investigating why GKE tests are failing and adding the changes on this very PR, but I'm happy to do it in a separate one.

@salasberryfin salasberryfin changed the title run gke e2e on pr ci WIP: run gke e2e on pr ci Apr 3, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2025
@salasberryfin
Copy link
Contributor Author

salasberryfin commented May 16, 2025 •
edited
Loading

/retest

@k8s-ci-robot
Copy link
Contributor

@salasberryfin: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-gcp-build

/test pull-cluster-api-provider-gcp-e2e-test

/test pull-cluster-api-provider-gcp-make

/test pull-cluster-api-provider-gcp-test

/test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-gcp-apidiff

/test pull-cluster-api-provider-gcp-capi-e2e

/test pull-cluster-api-provider-gcp-conformance

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

/test pull-cluster-api-provider-gcp-coverage

/test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-gcp-apidiff

pull-cluster-api-provider-gcp-build

pull-cluster-api-provider-gcp-e2e-test

pull-cluster-api-provider-gcp-make

pull-cluster-api-provider-gcp-test

pull-cluster-api-provider-gcp-verify

In response to this:

/retest pull-cluster-api-provider-gcp-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@salasberryfin
Copy link
Contributor Author

/test pull-cluster-api-provider-gcp-e2e-test

@k8s-ci-robot
Copy link
Contributor

@salasberryfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-e2e-test d0de097 link true /test pull-cluster-api-provider-gcp-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

@dims dims Awaiting requested review from dims

@richardcase richardcase Awaiting requested review from richardcase

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salasberryfin @k8s-ci-robot @richardcase @barbacbd