Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump k8s, CR, CG and deps #2395

Merged
merged 4 commits into from
Jan 29, 2025
Merged

🌱 Bump k8s, CR, CG and deps #2395

merged 4 commits into from
Jan 29, 2025

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Jan 24, 2025 •
edited
Loading

What this PR does / why we need it:

go.mod updates

  • k8s.io/api and deps to v0.32.1
  • CAPI to latest commit (unreleased)
  • sigs.k8s.io/controller-runtime to v0.20.1
  • k8s.io/code-generator to v0.32.1
  • sigs.k8s.io/controller-tools to v0.17.1

API violations

Update CAPI API violations

Generated code

Run make generate to produce new code.

Bump CAPI to future 1.10 in e2e

In the e2e configuration, we now deploy CAPI from a nightly build to get the future 1.10 version (unreleased now).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 24, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 380d5c6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6798e26fe0ceb0000948dcd0
😎 Deploy Preview https://deploy-preview-2395--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/hold
purely for science now

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/hold cancel
this passed all CI jobs and I checked, new CAPI was deployed.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@EmilienM
Copy link
Contributor Author

@lentzi90 @mdbooth for review, thanks

@EmilienM EmilienM mentioned this pull request Jan 27, 2025
Closed
lentzi90
lentzi90 reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit below. This looks otherwise good to me

test/e2e/data/e2e_conf.yaml Show resolved Hide resolved
@mdbooth
Copy link
Contributor

mdbooth commented Jan 28, 2025

What's the thinking behind the bump to unreleased CAPI?

@EmilienM
Copy link
Contributor Author

What's the thinking behind the bump to unreleased CAPI?

To get the new API changes and test everything is alright before they release as well. CAPV does it as well.

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM EmilienM requested a review from lentzi90 January 28, 2025 14:36
@EmilienM
Copy link
Contributor Author

can we please land this one? unless there is pushback.

lentzi90
lentzi90 reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this and I think it is good to test the latest CAPI code. We should point to a proper release when we push tags though.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2025
@EmilienM
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/hold
to see if CI passed again. We have seen issues in periodics.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@EmilienM
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit f879852 into kubernetes-sigs:main Jan 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
CAPO Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilienM @mdbooth @k8s-ci-robot @lentzi90