Skip to content

🌱 Add ClusterClass topology tests for ubuntu and bastion#3121

Open
larainema wants to merge 1 commit intokubernetes-sigs:mainfrom
larainema:feat/clusterclass-topology-tests
Open

🌱 Add ClusterClass topology tests for ubuntu and bastion#3121
larainema wants to merge 1 commit intokubernetes-sigs:mainfrom
larainema:feat/clusterclass-topology-tests

Conversation

@larainema
Copy link
Copy Markdown
Contributor

What issue does this PR address?

Issue #2796

What does this PR do?

Adds two new non-PR-blocking ClusterClass test variants to the e2e test suite:

  1. topology-ubuntu: Tests the ClusterClass with a standard ubuntu image without ignition/sysext configuration (injectIgnitionSysext: false)
  2. topology-bastion: Tests the ClusterClass with a standard ubuntu image and bastion enabled (bastion.enabled: true)

These complement the existing [PR-Blocking] topology test (which uses flatcar + ignition/sysext) by exercising additional variable combinations of the dev-test ClusterClass.

Changes

  • New kustomize overlays: topology-ubuntu/ and topology-bastion/
  • New test file: clusterclass_test.go with two QuickStartSpec tests tagged [ClusterClass] only (not [PR-Blocking])
  • New flavor constants: FlavorTopologyUbuntu and FlavorTopologyBastion
  • Updated Makefile and e2e_conf.yaml to register the new templates

Why not PR-blocking?

As noted in the issue, these tests should run in the periodic/full suite only to avoid adding to PR verification time. They are tagged with [ClusterClass] but intentionally omit the [PR-Blocking] tag.

Add two new non-PR-blocking ClusterClass test variants:

- topology-ubuntu: Tests ClusterClass with a standard ubuntu image
  without ignition/sysext configuration
- topology-bastion: Tests ClusterClass with a standard ubuntu image
  and bastion enabled

These tests exercise additional ClusterClass configurations beyond
the existing flatcar+sysext PR-blocking test, verifying that the
ClusterClass works correctly with different variable combinations.

The tests are not tagged as PR-Blocking so they only run in the
full periodic test suite.
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 16, 2026

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 15dd111
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/69e0ca80c4975e00082a6a22
😎 Deploy Preview https://deploy-preview-3121--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @larainema. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 16, 2026
@nikParasyr
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2026
@lentzi90
Copy link
Copy Markdown
Contributor

/test pull-cluster-api-provider-openstack-e2e-full-test

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@larainema: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-full-test 15dd111 link false /test pull-cluster-api-provider-openstack-e2e-full-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

4 participants