-
Notifications
You must be signed in to change notification settings - Fork 301
🌱 Changes for community owned Prow CI #3473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/hold |
/retest |
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
-config "$(TEST_INFRA_DIR)/config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-prowjob-gen.yaml" \ | ||
-templates-dir "$(TEST_INFRA_DIR)/config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/templates" \ | ||
-output-dir "$(TEST_INFRA_DIR)/config/jobs/kubernetes-sigs/cluster-api-provider-vsphere" | ||
rm $(TEST_INFRA_DIR)/config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-main-periodics-kubetest.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to skip them as a start. We did not even run them in mirror prow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They've never been green either and we currently have no plans to revive the work for them so maybe we should remove them for now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to skip
As a follow up, let's can drop this tests.
We know it is possible to run those tests, we know there are test cases that requires to be improved because they some assumption on the infrastructure layer that doesn't apply well to vSphere (and probably to other infrastructure as well).
But we don't have plans to fix this in the foreseeable future, so I think we can consider this experiment concluded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
/test pull-cluster-api-provider-vsphere-janitor-main |
70a45ad
to
8075305
Compare
/test pull-cluster-api-provider-vsphere-janitor-main |
8075305
to
5f93d4d
Compare
/test pull-cluster-api-provider-vsphere-janitor-main |
1 similar comment
/test pull-cluster-api-provider-vsphere-janitor-main |
b2efc2d
to
c991fbe
Compare
/test pull-cluster-api-provider-vsphere-janitor-main |
c991fbe
to
ab9302e
Compare
/test pull-cluster-api-provider-vsphere-janitor-main |
2 similar comments
/test pull-cluster-api-provider-vsphere-janitor-main |
/test pull-cluster-api-provider-vsphere-janitor-main |
68b9bd5
to
06190ac
Compare
06190ac
to
7faf017
Compare
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main |
/retest |
Let's see if this one is reproducible: /pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main Anti-affinity should now work |
Let's see if this one is reproducible: /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main |
/retest |
@chrischdi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
192.168.128.0/17
to not overlap with Prow CI's networks.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #