-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update KubeVirt quickstart guide #11734
Conversation
Would be good if a maintainer of the kubevirt provider can do a review EDIT: Just saw your comment on the other PR :). In general would be just good to have a review from someone additional that is familiar with the topic. I can then take a final look and merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nunnatsa. Left some comments.
e9cd72b
to
2e82544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this makes more sense to me. Left a few last nitpicks around language.
The KubeVirt sections in the quickstart guide are a bit old, and are not working as expected, as result of changes in several components. This PR updates the old KubeVirt sections, to a working instructions. In addition, the guide now presents all the supported boot images. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
2e82544
to
240ccfa
Compare
/lgtm |
LGTM label has been added. Git tree hash: 5f4d4035bc7b6071676b0cadc59971f0036b5039
|
/lgtm |
/ok-to-test |
/cc @chrischdi Could you please approve? |
Thx! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The KubeVirt sections in the quickstart guide are a bit old, and are not working as expected, as result of changes in several components.
This PR updates the old KubeVirt sections, to a working instructions. In addition, the guide now presents all the supported boot images.
/area documentation