-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 CAPD(Dev) Proposal #11754
base: main
Are you sure you want to change the base?
📖 CAPD(Dev) Proposal #11754
Conversation
cc @elmiko |
thank you @fabriziopandini ! /assign elmiko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i love the motivation for this and the direction it proposes. no suggestions from me currently, i would absolutely bring the kubemark provider into CAPD(ev).
thank you Fabrizio!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, pending comments :-)
LGTM label has been added. Git tree hash: 81826af5499560f6dcafa920c8d751e9df61cb08
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: a5c697859bfbedf628d9be9e2c4c22661d66875d
|
i'm happy to see this proposal move forward. i've also been thinking about MachinePool for CAPK, i think it's a great topic for future work. /lgtm |
we are setting lazy consensus for 7 February, if you have concerns with this proposal please raise them. |
What this PR does / why we need it:
This document proposes to evolve the CAPD(docker) provider into a more generic CAPD(dev) provider
supporting multiple backends including docker, in-memory, may be also kubemark.
The goal is to reduce toil and maintenance effort for infrastructure provider designed for development and test.