Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 CAPD(Dev) Proposal #11754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This document proposes to evolve the CAPD(docker) provider into a more generic CAPD(dev) provider
supporting multiple backends including docker, in-memory, may be also kubemark.

The goal is to reduce toil and maintenance effort for infrastructure provider designed for development and test.

@fabriziopandini fabriziopandini added area/testing Issues or PRs related to testing area/devtools Issues or PRs related to devtools area/ci Issues or PRs related to ci area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider area/provider/infrastructure-in-memory Issues or PRs related to the in-memory infrastructure provider labels Jan 24, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
@fabriziopandini
Copy link
Member Author

cc @elmiko

@elmiko
Copy link
Contributor

elmiko commented Jan 24, 2025

thank you @fabriziopandini !

/assign elmiko

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love the motivation for this and the direction it proposes. no suggestions from me currently, i would absolutely bring the kubemark provider into CAPD(ev).

thank you Fabrizio!

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, pending comments :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 81826af5499560f6dcafa920c8d751e9df61cb08

@chrischdi chrischdi removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrischdi. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5c697859bfbedf628d9be9e2c4c22661d66875d

@elmiko
Copy link
Contributor

elmiko commented Jan 27, 2025

i'm happy to see this proposal move forward. i've also been thinking about MachinePool for CAPK, i think it's a great topic for future work.

/lgtm

@elmiko
Copy link
Contributor

elmiko commented Jan 29, 2025

we are setting lazy consensus for 7 February, if you have concerns with this proposal please raise them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to ci area/devtools Issues or PRs related to devtools area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider area/provider/infrastructure-in-memory Issues or PRs related to the in-memory infrastructure provider area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants