-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 ClusterCache: Increase timeout for informer List+Watch calls from 10s to 11m #11757
🐛 ClusterCache: Increase timeout for informer List+Watch calls from 10s to 11m #11757
Conversation
/test pull-cluster-api-e2e-main |
650cea2
to
74885dd
Compare
/test pull-cluster-api-e2e-main |
I'll take a look at the unit tests |
/test pull-cluster-api-test-main |
74885dd
to
6a87501
Compare
/test pull-cluster-api-test-main |
/test pull-cluster-api-e2e-main |
/assign @vincepri @fabriziopandini @chrischdi |
Prod code is definitely fine for review, but I have to take another look at the tests. I thought they are green & stable but looks like they are not yet /hold |
6a87501
to
efbe57d
Compare
efbe57d
to
f48063a
Compare
Should be fine now. Just had to add the shutdown in more places /hold cancel |
/test pull-cluster-api-e2e-main |
Thanks for fixing this long standing issue! |
LGTM label has been added. Git tree hash: 9e2a2a05d2e004ffea0ce8e20cac03afa8cbcdb7
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.9 |
@sbueringer: new pull request created: #11767 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8893