Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ClusterCache: Increase timeout for informer List+Watch calls from 10s to 11m #11757

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jan 27, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8893

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jan 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from enxebre January 27, 2025 14:25
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from vincepri January 27, 2025 14:25
@sbueringer sbueringer changed the title ClusterCache: Increase timeout for informer List+Watch calls from 10s to 11m 🐛 ClusterCache: Increase timeout for informer List+Watch calls from 10s to 11m Jan 27, 2025
@sbueringer sbueringer added the area/clustercache Issues or PRs related to the clustercachetracker label Jan 27, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jan 27, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-poc-watch-timeout branch from 650cea2 to 74885dd Compare January 27, 2025 14:28
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member Author

I'll take a look at the unit tests

@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-main

@sbueringer sbueringer force-pushed the pr-poc-watch-timeout branch from 74885dd to 6a87501 Compare January 27, 2025 18:04
@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-main

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member Author

/assign @vincepri @fabriziopandini @chrischdi

@sbueringer
Copy link
Member Author

Prod code is definitely fine for review, but I have to take another look at the tests. I thought they are green & stable but looks like they are not yet

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
@sbueringer sbueringer force-pushed the pr-poc-watch-timeout branch from 6a87501 to efbe57d Compare January 27, 2025 18:11
@sbueringer sbueringer force-pushed the pr-poc-watch-timeout branch from efbe57d to f48063a Compare January 27, 2025 18:16
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2025
@sbueringer
Copy link
Member Author

Should be fine now. Just had to add the shutdown in more places

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@fabriziopandini
Copy link
Member

Thanks for fixing this long standing issue!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e2a2a05d2e004ffea0ce8e20cac03afa8cbcdb7

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit b8d827c into kubernetes-sigs:main Jan 28, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jan 28, 2025
@sbueringer sbueringer deleted the pr-poc-watch-timeout branch January 28, 2025 17:10
@sbueringer
Copy link
Member Author

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #11767

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clustercache Issues or PRs related to the clustercachetracker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watches on remote cluster expires every 10s
6 participants