🌱 Attempt older version upgrades twice to work around flake with the docker controller #11759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/e2e-testing
k8s-ci-robot
added
needs-rebase
…e docker controller Signed-off-by: cprivitere <[email protected]>
cprivitere
force-pushed
the
clusterctl-upgrade-flakeattempts
branch
from
c3585e6 to
e6bb305
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d6a7cb7b308a1d865df535395ec61baa0f1b541d
|
|
Thank you! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This is a recommendation from this comment #11610 (comment) in #11610 to work around flaky upgrade tests and improve our CI signal. The root cause seems to be related to the docker controller but only affects older versions. So the goal is to just reduce the flakey signal by retrying the tests on those older versions (which just show up in our upgrade tests).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #11209
Fixes #11610
/area e2e-testing