Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Adopt e2e labels usage #11763

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cahillsf
Copy link
Member

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
part of #9620

/area e2e-testing

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2025
@@ -978,7 +979,7 @@ test-test-extension-junit: $(SETUP_ENVTEST) $(GOTESTSUM) ## Run unit and integra
.PHONY: test-e2e
test-e2e: $(GINKGO) generate-e2e-templates ## Run the end-to-end tests
$(GINKGO) -v --trace -poll-progress-after=$(GINKGO_POLL_PROGRESS_AFTER) \
-poll-progress-interval=$(GINKGO_POLL_PROGRESS_INTERVAL) --tags=e2e --focus="$(GINKGO_FOCUS)" \
-poll-progress-interval=$(GINKGO_POLL_PROGRESS_INTERVAL) --tags=e2e --focus="$(GINKGO_FOCUS)" --label-filter="$(GINKGO_LABEL_FILTER)" \
Copy link
Member Author

@cahillsf cahillsf Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these different methods of filtering get ANDed (https://onsi.github.io/ginkgo/#combining-filters)

@cahillsf
Copy link
Member Author

cahillsf commented Jan 28, 2025

my idea is to merge this on main, then proceed with the following at each step ensuring the "same" specs/tests are running

not sure if its worth automating? doesn't seems there's a great way to just get the selected specs except using -v --dry-run but that gives.. verbose output, open to ideas here

  • follow up with a PR in test-infra that adds the GINKGO_LABEL_FILTER to main e2e testing suites
  • remove the "legacy" ginkgo envvar filters in test-infra main e2e testing suites
  • migrate k8s::prepareKindestImagesVariablesGingkoFilters logic to k8s::prepareKindestImagesVariables and get rid of the duplicated function in sripts/ci-e2e-lib.sh (and get rid of the corresponding if/else i added in scripts/ci-e2e.sh )
  • update the templates in test-infra to reflect the new envvars only

@cahillsf cahillsf marked this pull request as ready for review January 28, 2025 00:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025
@cahillsf cahillsf changed the title 🌱 Adopt e2e labels usage [WIP] 🌱 Adopt e2e labels usage Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025
@cahillsf cahillsf changed the title [WIP] 🌱 Adopt e2e labels usage 🌱 Adopt e2e labels usage Jan 28, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants