-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[WIP] Race Condition where controller marks provisioned #12347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d1f635d
to
9dcf6df
Compare
9dcf6df
to
21b1255
Compare
test result of d290d64:
|
What this PR does / why we need it:
The controller returned ctrl.Result{} (no requeue) too early.
The test expects a requeue ctrl.Result{RequeueAfter: ...} until the provisioning duration has finished.
If res is equal to 0 then reconciliation will not be requeued, but it should be requeued and equal to 0.
if now < until then res != 0 and we requeue
if now >= until then res == 0 and we do not requeue (provisioned)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #12301