🌱 add new machinepool spec type#13522
🌱 add new machinepool spec type#13522mpinchover wants to merge 5 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
|
Please provide context why we would add an unused struct like this to the v1beta1 API |
mpinchover
changed the title
k8s-ci-robot
added
size/L
| // fields to configure the Machine’s bootstrapping mechanism. | ||
| // The configuration applies to all machines in the pool. | ||
| // +required | ||
| Bootstrap *Bootstrap `json:"bootstrap,omitempty"` |
There was a problem hiding this comment.
Should this really be +required (as questioned in the design doc)? If so, it probably shouldn't be a pointer field with omitempty.
| // offered by an infrastructure provider. | ||
| // The custom resource is applied to all machines in the pool. | ||
| // +required | ||
| InfrastructureRef corev1.ObjectReference `json:"infrastructureRef,omitempty"` |
There was a problem hiding this comment.
Should this be a ContractVersionedObjectReference instead? That's the v1beta2 way AFAICT.
| ). | ||
| */ | ||
|
|
||
| // MachinePoolTemplateSpec describes the data needed to create |
There was a problem hiding this comment.
Kind of nitpicky, but since Machines in a MachinePool are typically managed by the infra provider rather than created by CAPI, maybe this comment would be more accurate if it said something like
MachinePoolTemplateSpec describes the desired configuration for machines in a MachinePool.
| // Configuration is applied to all machines in the pool. | ||
| // +optional | ||
| Deletion MachineDeletionSpec `json:"deletion,omitzero,omitempty"` | ||
| } |
There was a problem hiding this comment.
The doc mentions Taints as an optional field but I don't see it in here.
5 participants
What this PR does / why we need it:
Following up on this doc for updating the machinepool CRD, this is PR 1/n for implementation
Follow up PR's will wire up the new template in the machine pool spec to keep things small and easy to review.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #9005
/area machinepool