Skip to content

🐛 sort manifest webhooks #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2025
Merged

🐛 sort manifest webhooks #1295

merged 3 commits into from
Nov 1, 2025

Conversation

@HaraldNordgren
Copy link
Contributor

@HaraldNordgren HaraldNordgren commented Oct 23, 2025 •
edited
Loading

Orders the webhook manifest so traversal order doesn't matter. Fixes #900.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 23, 2025

Welcome @HaraldNordgren!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 23, 2025

Hi @HaraldNordgren. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2025
@HaraldNordgren HaraldNordgren force-pushed the sort_version_2 branch 3 times, most recently from 0e01915 to 72091c6 Compare October 23, 2025 22:44
@HaraldNordgren HaraldNordgren changed the title webhook: sort on version if names are equal 🐛 webhook: sort on version if names are equal Oct 23, 2025
@HaraldNordgren HaraldNordgren changed the title 🐛 webhook: sort on version if names are equal 🐛 controller-gen: sort webhook manifest order Oct 23, 2025
@HaraldNordgren HaraldNordgren mentioned this pull request Oct 23, 2025
Closed
@HaraldNordgren HaraldNordgren marked this pull request as ready for review October 23, 2025 22:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot requested a review from vincepri October 23, 2025 22:54
@HaraldNordgren
Copy link
Contributor Author

HaraldNordgren commented Oct 27, 2025

Ping @jmeyers35 @sbueringer

dongjiang1989
dongjiang1989 reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@dongjiang1989 dongjiang1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2025
@sbueringer
Copy link
Member

sbueringer commented Oct 28, 2025

/assign

@HaraldNordgren HaraldNordgren changed the title 🐛 controller-gen: sort webhook manifest order 🐛 sort controller-gen webhook manifest order Oct 28, 2025
@HaraldNordgren HaraldNordgren changed the title 🐛 sort controller-gen webhook manifest order 🐛 sort controller-gen webhook manifests Oct 28, 2025
@HaraldNordgren HaraldNordgren changed the title 🐛 sort controller-gen webhook manifests 🐛 sort controller-gen webhooks Oct 28, 2025
@HaraldNordgren HaraldNordgren changed the title 🐛 sort controller-gen webhooks 🐛 sort manifest webhooks Oct 28, 2025
@sbueringer
Copy link
Member

sbueringer commented Nov 1, 2025

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 1, 2025

LGTM label has been added.

Git tree hash: e1fb34a4f5eec4748ad119c18816e45c274c038e

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HaraldNordgren, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9fb4c06 into kubernetes-sigs:main Nov 1, 2025
8 checks passed
HaraldNordgren pushed a commit to HaraldNordgren/controller-tools that referenced this pull request Nov 1, 2025
@k8s-ci-robot @HaraldNordgren
Merge pull request kubernetes-sigs#1295 from HaraldNordgren/sort_vers…
9f09425 
…ion_2

🐛 sort manifest webhooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford Awaiting requested review from joelanford

@sbueringer sbueringer Awaiting requested review from sbueringer

@vincepri vincepri Awaiting requested review from vincepri

@dongjiang1989 dongjiang1989 Awaiting requested review from dongjiang1989

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

controller-gen: webhook manifest order can change unexpectedly

5 participants

@HaraldNordgren @k8s-ci-robot @JoelSpeed @sbueringer @dongjiang1989