Add DRA NUMA list attribute by killianmuldoon · Pull Request #283 · kubernetes-sigs/dranet

killianmuldoon · 2026-08-10T13:49:03Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR uses the upstream DRA NUMA helpers to enable reporting of the upstream standard NUMA List attribute in DRANet where available. The list attribute is described in a KEP. It enables matching by closest NUMA on more complex hardware where the network device NUMA node may not directly match the node of other hardware.

A bump to Kubernetes 1.37-rc.0 libraries is included as a dependency. This feature is enabled with a feature gate on Kubernetes 1.37, and the upstream helper libraries are only available in 1.37 tags.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added - standardized NUMA list attribute behind feature gate.

netlify · 2026-08-10T13:49:10Z

✅ Deploy Preview for dranet canceled.

Name	Link
🔨 Latest commit	`4224279`
🔍 Latest deploy log	https://app.netlify.com/projects/dranet/deploys/6a85700e2b250c0008f0d270

killianmuldoon · 2026-08-10T13:50:32Z

+// WatchHealthStatus implements the Kubernetes 1.37 DRAPlugin contract. DRANET
+// disables the optional health service.
+func (np *NetworkDriver) WatchHealthStatus(context.Context, chan<- kubeletplugin.DeviceHealthReport) error {
+	return kubeletplugin.ErrHealthNotSupported


This is required in 1.37 - but not implemented as part of this change. I imagine it needs a good amount more conversation.

Is have a stub implementation required or optional?

It's a required part of the interface in 1.37 - it was added to the DRAPlugin interface as part of this change.

Gotcha, thanks!

@killianmuldoon please add a TODO, we already report health so implementing this sounds reasonable if helps reliability ... although I want to understand better this feature , how it works and what problems solve

WatchHealthStatus is about device health that can be propagated all the way to the workload pod's status containerStatus.AllocatedResourcesStatus if the device claimed by the the pod becomes unhealthy. It is sort of alternative (if we can say so) to the events which is general but this is specifically for the DRA drivers.

xref: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4680-add-resource-health-to-pod-status/README.md

we definitively should have this , but also put some user stories on how we want to implement it , opened #293 for tracking, just add TODO and reference that issue please

I added a TODO with a link to the issue - let me know if you'd prefer a different format or wording.

gauravkghildiyal

Thanks @killianmuldoon

gauravkghildiyal · 2026-08-13T05:25:37Z

+// WatchHealthStatus implements the Kubernetes 1.37 DRAPlugin contract. DRANET
+// disables the optional health service.
+func (np *NetworkDriver) WatchHealthStatus(context.Context, chan<- kubeletplugin.DeviceHealthReport) error {
+	return kubeletplugin.ErrHealthNotSupported


Is have a stub implementation required or optional?

gauravkghildiyal

Thanks @killianmuldoon. Took a closer look, mostly looking good.

One request I had was if we could be a slightly more detailed with the release notes. For example, let's include the full attribute name of the attribute being added. Also, there is this bit of nuance with the standard NUMA attribute that I remember discussing which we should be linking to https://www.kubernetes.dev/resources/keps/6072/#consumer-expectations.

gauravkghildiyal · 2026-08-15T02:20:36Z

+// WatchHealthStatus implements the Kubernetes 1.37 DRAPlugin contract. DRANET
+// disables the optional health service.
+func (np *NetworkDriver) WatchHealthStatus(context.Context, chan<- kubeletplugin.DeviceHealthReport) error {
+	return kubeletplugin.ErrHealthNotSupported


Gotcha, thanks!

gauravkghildiyal · 2026-08-15T02:23:59Z

+				db.deviceAttributeMachineModifiers...,
+			)
+			if err != nil {
+				klog.V(4).Infof("Not publishing standardized NUMA attribute for PCI device %s: %v", normalizedAddr, err)


Should we log this as Error instead?

(Matches the other standard attribute GetPCIeRootAttributeByPCIBusID handling)

I'm not so sure here - the error could be very noisy if there's devices without NUMA information. That could potentially happen on some VM setups. That said I'm happy either way here.

You're right. Thinking about this more, GetPCIeRootAttributeByPCIBusID has a less chance of failing compared to NUMA (just because a PCI Device is more than likely to have a PCIe root, but not necessary have NUMA information populated). Sorry for asking you to change it back to the original.

No issue changing it back - set it to Info now!

gauravkghildiyal · 2026-08-15T02:35:48Z

 		_ = db.addPCIAttributes(devices, nil)
 	})
+
+	t.Run("publishes standardized scalar NUMA attribute by default", func(t *testing.T) {


The tests are helpful. Thanks for adding them!

aojea · 2026-08-18T11:14:20Z

This feature is enabled with a feature gate on Kubernetes 1.37, and the upstream helper libraries are only available in 1.37 tags.

@gauravkghildiyal any special reason to feature gate this option? is a read only attribute from a kubernetes well defined value so it feels we should expose it once we move to 1.37

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

gauravkghildiyal · 2026-08-19T01:52:33Z

This feature is enabled with a feature gate on Kubernetes 1.37, and the upstream helper libraries are only available in 1.37 tags.

@gauravkghildiyal any special reason to feature gate this option? is a read only attribute from a kubernetes well defined value so it feels we should expose it once we move to 1.37

This is slightly confusing and non-ideal from upstream itself, but the idea is that the attribute resource.kubernetes.io/numaNode can both be a scalar value (e.g. 0) or a list value (e.g. [0, 1, 2, 3]).

Defining a "list" type attribute is still alpha in DRA. So what this change is feature gating is NOT whether to publish the attribute, but whether to publish it as a scalar or a list. If you think when we change this from scalar to list then it would be a breaking change, you are right, but that's the recommendation https://www.kubernetes.dev/resources/keps/6072/#consumer-expectations without an alternative option.

gauravkghildiyal · 2026-08-19T01:52:57Z

@killianmuldoon One last thing and we should be good: #283 (comment)

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

gauravkghildiyal · 2026-08-20T06:21:52Z

/label tide/merge-method-squash
/lgtm
/approve

kubernetes-prow · 2026-08-20T06:22:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [gauravkghildiyal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 10, 2026

kubernetes-prow Bot requested review from MikeZappa87 and anson627 August 10, 2026 13:49

kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2026

killianmuldoon commented Aug 10, 2026

View reviewed changes

Comment thread cmd/webhook-whereabouts/go.sum

killianmuldoon commented Aug 10, 2026

View reviewed changes

gauravkghildiyal reviewed Aug 13, 2026

View reviewed changes

gauravkghildiyal reviewed Aug 15, 2026

View reviewed changes

killianmuldoon changed the title ~~Add DRA NUMA list attribute when available~~ Add DRA NUMA list attribute Aug 17, 2026

kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2026

aojea mentioned this pull request Aug 18, 2026

WatchHealthStatus Implementation #293

Open

killianmuldoon added 6 commits August 18, 2026 13:51

Bump Kubernetes dependencies to v1.37.0-rc.0

09935f4

Ignore IntelliJ IDEA project files

fed3470

Publish standardized DRA NUMA node attributes

a7fdaf0

docs: add explanation of how to use list attributes for NUMA

7314fca

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

fix: consolidate PCI attribute scanning and error handling

8388941

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

fix: add todo for WatchHealthStatus stub implementation

ea393a7

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

killianmuldoon force-pushed the pr-dra-list branch from f126de3 to ea393a7 Compare August 18, 2026 12:51

kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2026

fix: missing numa attribute should not emit error log

4224279

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

kubernetes-prow Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 20, 2026

kubernetes-prow Bot assigned gauravkghildiyal Aug 20, 2026

kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2026

kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2026

Uh oh!

Conversation

killianmuldoon commented Aug 10, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

netlify Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for dranet canceled.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

killianmuldoon Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gauravkghildiyal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gauravkghildiyal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aojea commented Aug 18, 2026

Uh oh!

gauravkghildiyal commented Aug 19, 2026

Uh oh!

gauravkghildiyal commented Aug 19, 2026

Uh oh!

gauravkghildiyal commented Aug 20, 2026

Uh oh!

kubernetes-prow Bot commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify Bot commented Aug 10, 2026 •

edited

Loading

killianmuldoon Aug 14, 2026 •

edited

Loading