Add extraVolumes and extraVolumeMounts to the Helm chart - #286
Conversation
✅ Deploy Preview for dranet canceled.
|
|
Hi @OguzPastirmaci. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fmuyassarov
left a comment
There was a problem hiding this comment.
LGTM, apart from one comment below.
|
/ok-to-test |
|
/assign @fmuyassarov |
bbb17ea to
e8480b2
Compare
fmuyassarov
left a comment
There was a problem hiding this comment.
Thank you.
/lgtm
/cc @gauravkghildiyal
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, OguzPastirmaci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds
extraVolumesandextraVolumeMountsvalues to the Helm chart. Some deployments need host files mounted into the driver, for example a cloud provider agent configuration directory. The chart adds the entries after the built-in volumes without changes. The values schema requiresnameandmountPath. The Helm CI workflow renders the new path and checks the output.install.yamlgets a commented example.Which issue(s) this PR is related to:
None
Does this PR introduce a user-facing change?