Download bpftool to a file before extracting in e2e tests - #287
Conversation
✅ Deploy Preview for dranet canceled.
|
|
Hi @OguzPastirmaci. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
4d39007 to
4d885ea
Compare
|
Thanks @OguzPastirmaci /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, OguzPastirmaci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The e2e tests downloaded bpftool anonymously inside the cluster in two places: on the kind node and in the test pod. These downloads fail when the GitHub release CDN returns errors to shared runner addresses, which failed the bpf tests (for example this run). An earlier version of this PR kept the in-cluster downloads and added retries, and CI failed the same way.
This version removes the in-cluster downloads. The bats workflow downloads bpftool once on the runner with an authenticated
gh release download, with retries and--clobber. The tests copy the binary into the kind node withdocker cpand into the test pod withkubectl cp. Local runs without a token keep a curl fallback. Verified green on a fork run of the bats workflow.Which issue(s) this PR is related to:
None
Does this PR introduce a user-facing change?