Skip to content

Download bpftool to a file before extracting in e2e tests - #287

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
OguzPastirmaci:e2e-bpftool-download
Aug 15, 2026
Merged

Download bpftool to a file before extracting in e2e tests#287
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
OguzPastirmaci:e2e-bpftool-download

Conversation

@OguzPastirmaci

@OguzPastirmaci OguzPastirmaci commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The e2e tests downloaded bpftool anonymously inside the cluster in two places: on the kind node and in the test pod. These downloads fail when the GitHub release CDN returns errors to shared runner addresses, which failed the bpf tests (for example this run). An earlier version of this PR kept the in-cluster downloads and added retries, and CI failed the same way.

This version removes the in-cluster downloads. The bats workflow downloads bpftool once on the runner with an authenticated gh release download, with retries and --clobber. The tests copy the binary into the kind node with docker cp and into the test pod with kubectl cp. Local runs without a token keep a curl fallback. Verified green on a fork run of the bats workflow.

Which issue(s) this PR is related to:

None

Does this PR introduce a user-facing change?

NONE

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Aug 12, 2026
@netlify

netlify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Deploy Preview for dranet canceled.

Name Link
🔨 Latest commit 4d885ea
🔍 Latest deploy log https://app.netlify.com/projects/dranet/deploys/6a7e02d3ed05fc000841b44f

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @OguzPastirmaci. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2026
@gauravkghildiyal

Copy link
Copy Markdown
Member

/ok-to-test
/retest

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2026
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2026
@gauravkghildiyal

Copy link
Copy Markdown
Member

Thanks @OguzPastirmaci

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, OguzPastirmaci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 9760b79 into kubernetes-sigs:main Aug 15, 2026
13 checks passed
@OguzPastirmaci
OguzPastirmaci deleted the e2e-bpftool-download branch August 15, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants