Skip to content

Conversation

@illume
Copy link
Contributor

@illume illume commented Oct 19, 2025

It used to be that a coverage report would be sent as a comment to
the PR if the PR has changes in backend/ folder.

Testing

  • Try adding a backend/ folder commit, and see the PR comment come

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2025
@illume illume force-pushed the backend-coverage-fix branch from 8a2fcee to 24cfe0b Compare October 19, 2025 16:40
@illume illume force-pushed the backend-coverage-fix branch from 24cfe0b to bf0a637 Compare October 19, 2025 17:02
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2025
@illume illume force-pushed the backend-coverage-fix branch 2 times, most recently from e17362e to 92309b3 Compare October 19, 2025 17:17
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2025
@illume illume force-pushed the backend-coverage-fix branch from 92309b3 to 74ec37b Compare October 19, 2025 17:25
It used to be that a coverage report would be sent as a comment to
the PR if the PR has changes in backend/ folder.
@illume illume force-pushed the backend-coverage-fix branch from 74ec37b to e4c3fca Compare October 19, 2025 17:27
@illume illume marked this pull request as draft October 20, 2025 11:23
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
@illume
Copy link
Contributor Author

illume commented Oct 20, 2025

The main issue is that forked PRs don't get access to a secret which gives them permission to comment on the PR.
Because none of our PRs use our own branches any more, it's not commenting anymore.

A possible fix?

Two step workflow:

  • backend-test.yml, runs tests, uploads artefacts
  • post-coverage-comment.yml, is triggered on workflow_run.completed of backend test finishes, downloads artefacts from the github.event.workflow_run.id and posts the comment (because it has more privs this is allowed)

Still not running code with secrets, the stuff requiring privs is done in a separate workflow. It can download from the forked artefacts because triggered jobs are given a run id.

@illume illume closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants