-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use self-affinity to ensure all pods schedule #1938
chore: Use self-affinity to ensure all pods schedule #1938
Conversation
fe3275d
to
49efd53
Compare
func BenchmarkScheduling10000(b *testing.B) { | ||
benchmarkScheduler(b, 400, 10000) | ||
} | ||
func BenchmarkScheduling20000(b *testing.B) { | ||
benchmarkScheduler(b, 400, 20000) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
pkg/controllers/provisioning/scheduling/scheduling_benchmark_test.go
Outdated
Show resolved
Hide resolved
49efd53
to
4f8068b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, rschalo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4f8068b
to
8075e68
Compare
/lgtm |
Fixes #N/A
Description
Use self-affinity to ensure that all pods schedule when executing the scheduling benchmark. This also expands the test case to run up to 20,000 pods since the tests are executing quicker now
Scheduling Benchmark
How was this change tested?
go test -bench=.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.