Skip to content

Conversation

@kersten
Copy link
Contributor

@kersten kersten commented Apr 1, 2025

Replaced usage of %v with %w in fmt.Errorf calls to enable proper error chaining across:

  • pkg/plugins/golang/repository.go
  • go_version.go
  • v4/scaffolds/api.go

Also improved formatting by quoting dynamic values with %q and removed redundant error wrapping logic.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kersten kersten changed the title 🌱 (chore): wrap errors using %w and improve formatting in golang plugin 🌱 (chore): wrap errors using '%w' and improve formatting in golang plugin Apr 1, 2025
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Improvements that follow Go best practices. No logic changes, so it's safe to merge. 👍

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, kersten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
@camilamacedo86 camilamacedo86 reopened this Apr 1, 2025
…ugin

Replaced usage of `%v` with `%w` in `fmt.Errorf` calls to enable proper error chaining across:
- `pkg/plugins/golang/repository.go`
- `go_version.go`
- `v4/scaffolds/api.go`

Also improved formatting by quoting dynamic values with `%q` and removed redundant error wrapping logic.
@kersten kersten force-pushed the chore/golang-error-wrapping branch from 72f7640 to 1d35e55 Compare April 2, 2025 14:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2025
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 02168ca into kubernetes-sigs:master Apr 2, 2025
22 checks passed
@kersten kersten deleted the chore/golang-error-wrapping branch April 3, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants