-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱 (chore): wrap errors using '%w' and improve formatting in golang plugin #4729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 (chore): wrap errors using '%w' and improve formatting in golang plugin #4729
Conversation
|
Hi @kersten. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
%w and improve formatting in golang plugin
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Improvements that follow Go best practices. No logic changes, so it's safe to merge. 👍
/lgtm
/approve
/ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, kersten The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ugin Replaced usage of `%v` with `%w` in `fmt.Errorf` calls to enable proper error chaining across: - `pkg/plugins/golang/repository.go` - `go_version.go` - `v4/scaffolds/api.go` Also improved formatting by quoting dynamic values with `%q` and removed redundant error wrapping logic.
72f7640 to
1d35e55
Compare
|
/lgtm |
Replaced usage of
%vwith%winfmt.Errorfcalls to enable proper error chaining across:pkg/plugins/golang/repository.gogo_version.gov4/scaffolds/api.goAlso improved formatting by quoting dynamic values with
%qand removed redundant error wrapping logic.