Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 (chore): use errors.As and wrap exec errors in repository.go #4730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🌱 (chore): use errors.As and wrap exec errors in repository.go #4730

wants to merge 1 commit into from

Conversation

kersten
Copy link
Contributor

@kersten kersten commented Apr 1, 2025

Refactored error handling in repository.go:

  • Replaced type assertion with errors.As for *exec.ExitError
  • Ensured command stderr is preserved in the wrapped fmt.Errorf output
  • Set up for better error introspection and debugging

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mateusoliveira43
mateusoliveira43 reviewed Apr 1, 2025
View reviewed changes
pkg/plugins/golang/repository.go
@@ -39,7 +40,8 @@ func findGoModulePath() (string, error) {
cmd.Env = append(cmd.Env, os.Environ()...)
out, err := cmd.Output()
if err != nil {
if exitErr, isExitErr := err.(*exec.ExitError); isExitErr {
var exitErr *exec.ExitError
if errors.As(err, &exitErr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not use errors.Is() here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check that out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errors.Is just checks the error and does not populate it to exitErr.

camilamacedo86
camilamacedo86 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improves error type handling and seems safe to merge.

/lgtm
/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, kersten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
@camilamacedo86 camilamacedo86 changed the title 🌱 (chore): use errors.As and wrap exec errors in repository.go 🌱 (chore): use errors.As and wrap exec errors in repository.go Apr 1, 2025
@camilamacedo86 camilamacedo86 reopened this Apr 1, 2025
@camilamacedo86 camilamacedo86 changed the title 🌱 (chore): use errors.As and wrap exec errors in repository.go 🌱 (chore): use errors.As and wrap exec errors in repository.go Apr 1, 2025
@kersten
🌱 (chore): use errors.As and wrap exec errors in repository.go
646d2b5 
Refactored error handling in `repository.go`:
- Replaced type assertion with `errors.As` for `*exec.ExitError`
- Ensured command stderr is preserved in the wrapped `fmt.Errorf` output
- Set up for better error introspection and debugging
@kersten kersten force-pushed the chore/golang-repository-error-handling branch from 0ad43be to 646d2b5 Compare April 2, 2025 14:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2025
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2025
@camilamacedo86 camilamacedo86 changed the title 🌱 (chore): use errors.As and wrap exec errors in repository.go 🌱 (chore): use errors.As and wrap exec errors in repository.go Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@mateusoliveira43 mateusoliveira43 Awaiting requested review from mateusoliveira43

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kersten @k8s-ci-robot @camilamacedo86 @mateusoliveira43