-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: helm install fails when deploying VAPs #89
base: main
Are you sure you want to change the base?
fix: helm install fails when deploying VAPs #89
Conversation
generate kind config
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AlexanderStocks The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @AlexanderStocks. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
/retitle fix: helm install fails when deploying VAPs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address the comment to make chart changes in manifest_staging
and then we can merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert changes to charts/
. Make the changes in manifest_staging
dir only and they'll be promoted to charts/
at the time of release.
generate kind config
What type of PR is this?
/kind bug
What this PR does / why we need it:
THis PR adds a makefile stage to generate a kind config to generate a kind config file to enable to right flags for the k8s version to enable VAPs.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #78
Special notes for your reviewer:
TODOs: