Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop mention of NodeFeature #8229

Merged
merged 1 commit into from
Jan 15, 2025
Merged

drop mention of NodeFeature #8229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contributors/devel/sig-node/e2e-node-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,10 @@ Image configuration files can further influence how FOCUS and SKIP match test ca
For example:

```sh
--focus="\[NodeFeature:.+\]" --skip="\[Flaky\]|\[Serial\]"
--focus="\[Feature:.+\]" --skip="\[Flaky\]|\[Serial\]"
```

runs all e2e tests labeled `"[NodeFeature:*]"` and will skip any tests labeled `"[Flaky]"` or `"[Serial]"`.
runs all e2e tests labeled `"[Feature:*]"` and will skip any tests labeled `"[Flaky]"` or `"[Serial]"`.

Two example e2e tests that match this expression are:
* https://github.com/kubernetes/kubernetes/blob/0e2220b4462130ae8a22ed657e8979f7844e22c1/test/e2e_node/security_context_test.go#L155
Expand Down Expand Up @@ -235,15 +235,15 @@ To run a particular e2e test, simply pass the Grinkgo `It` string to the `--focu
For example, suppose we have the following test case: https://github.com/kubernetes/kubernetes/blob/0e2220b4462130ae8a22ed657e8979f7844e22c1/test/e2e_node/security_context_test.go#L175. We could select this test case by adding the argument:

```sh
--focus="should not show its pid in the non-hostpid containers \[NodeFeature:HostAccess\]"
--focus="should not show its pid in the non-hostpid containers \[Feature:HostAccess\]"
```

## Run all tests related to a feature

In contrast, to run all node e2e tests related to the "HostAccess" feature one could run:

```sh
--focus="\[NodeFeature:HostAccess\]"
--focus="\[Feature:HostAccess\]"
```

## Run tests continually until they fail
Expand Down