Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog: New Release Opt-in process #334

Merged
merged 18 commits into from
Sep 9, 2022
Merged

Blog: New Release Opt-in process #334

merged 18 commits into from
Sep 9, 2022

Conversation

gracenng
Copy link
Member

@gracenng gracenng commented Sep 2, 2022 •
edited
Loading

Please make comments in the HackMD and I'll update the final copy in the file
HackMD: https://hackmd.io/@gracenng/B1Wa-lkxo

This blog communicates the replacements of the enhancement tracking sheet with the github project board starting in 1.26. This decision was reached in the second retro of the 1.25 release.

This is part of kubernetes/sig-release#2009
and https://docs.google.com/document/d/1t95jSLFfBY71S1bv6suwOuifZuMcXykKSVUsCWecgCM/edit?usp=sharing

/cc @rhockenbury @leonardpahlke @justaugustus @cici37 @Priyankasaggu11929 @reylejano

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 2, 2022
@gracenng gracenng marked this pull request as draft September 2, 2022 06:41
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2022
@gracenng
Copy link
Member Author

gracenng commented Sep 2, 2022

Brain dump and need more editing from my end. Anything else I should mention? I'd like to add an image of sorts as well

@marosset
Copy link

marosset commented Sep 2, 2022

We should explicitly state that sig leads should comment /label lead-opted-in on the enhancement issue (instead of just saying add the label).

@marosset
Copy link

marosset commented Sep 2, 2022

ex: kubernetes/enhancements#1981 (comment)

@marosset
Copy link

marosset commented Sep 2, 2022

Once kubernetes/k8s.io#4176 merges we can ask people to direct questions to [email protected]

rhockenbury
rhockenbury reviewed Sep 3, 2022
View reviewed changes
@gracenng gracenng marked this pull request as ready for review September 4, 2022 07:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2022
@gracenng
Copy link
Member Author

gracenng commented Sep 4, 2022

@reylejano - this is ready for review

@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@gracenng @reylejano
wording edits from rey
7bc3a34 
Co-authored-by: Rey Lejano <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@gracenng @reylejano
tag -> label
4863cd1 
Co-authored-by: Rey Lejano <[email protected]>
@gracenng @rhockenbury
grammar hehe
b07bd43 
Co-authored-by: Ryler Hockenbury <[email protected]>
@rhockenbury
Copy link
Contributor

Looks great. Thanks @gracenng.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@leonardpahlke
Copy link
Member

/assign @jeefy

@jberkus
Copy link
Contributor

jberkus commented Sep 9, 2022

This looks good, let's get it out the door.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gracenng, jberkus, leonardpahlke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@gracenng
Copy link
Member Author

gracenng commented Sep 9, 2022

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit cc647fb into kubernetes:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhockenbury rhockenbury rhockenbury left review comments

@marosset marosset marosset left review comments

@reylejano reylejano reylejano left review comments

@leonardpahlke leonardpahlke leonardpahlke approved these changes

@cici37 cici37 Awaiting requested review from cici37

@justaugustus justaugustus Awaiting requested review from justaugustus

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

@jberkus jberkus

@jeefy jeefy

@rhockenbury rhockenbury

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Contribex Comms Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gracenng @marosset @leonardpahlke @jberkus @reylejano @rhockenbury @k8s-ci-robot @jeefy