KEP-2535: document writes during MustAttemptImagePull()#5115
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Feb 5, 2025
Merged
Conversation
k8s-ci-robot
added
kind/kep
9 tasks
stlaz
force-pushed
the
ensure-secret-images-matching-writes
branch
from
d2be89e to
0262549
Compare
Member
|
@stlaz can you also take care of #2535 (comment) ? |
Member
Author
I believe this was already handled in #5026, is there anything else that I should do? |
Member
Looks like that was a mistake, so we are good. /lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/assign dchen1107 mrunalp |
mrunalp
approved these changes
Feb 5, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, mrunalp, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc liggitt enj