-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update groups.yaml Release Notes shadow 1.32 #7291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the comments should be Shadows not Lead. And Edith's comment should be for Release Notes right?
@satyampsoni just took a look, @gracenng already covered it :) If you could push an update we can proceed, thanks! |
Oops! It seems like I accidentally copied without editing, but I’ve fixed it now, @gracenng. As for Edith, she’s the comms shadow, and I was just organizing things in alphabetical order as @fsmunoz suggested in the slack message. Please let me know if i am getting that wrong, I can make like it was earlier. |
@satyampsoni sorting alphabetically is a requirement, it fails without it. @gracenng the Comms shadows are in through #7288 , went investigating because I thought it could still be an artefact of 1.31. (xref: kubernetes/sig-release#2603 ) |
/lgtm |
/approve |
/assign @justaugustus (I should be able to approve this myself, I'll go fix my own perms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, katcosgrove, satyampsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @fsmunoz @katcosgrove @gracenng