Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update groups.yaml Release Notes shadow 1.32 #7291

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

satyampsoni
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject labels Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from puerco September 12, 2024 20:11
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2024
Copy link
Member

@gracenng gracenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the comments should be Shadows not Lead. And Edith's comment should be for Release Notes right?

@fsmunoz
Copy link
Contributor

fsmunoz commented Sep 13, 2024

@satyampsoni just took a look, @gracenng already covered it :) If you could push an update we can proceed, thanks!

@satyampsoni
Copy link
Member Author

satyampsoni commented Sep 13, 2024

Oops! It seems like I accidentally copied without editing, but I’ve fixed it now, @gracenng. As for Edith, she’s the comms shadow, and I was just organizing things in alphabetical order as @fsmunoz suggested in the slack message. Please let me know if i am getting that wrong, I can make like it was earlier.

@fsmunoz
Copy link
Contributor

fsmunoz commented Sep 13, 2024

@satyampsoni sorting alphabetically is a requirement, it fails without it.

@gracenng the Comms shadows are in through #7288 , went investigating because I thought it could still be an artefact of 1.31.

(xref: kubernetes/sig-release#2603 )

@fsmunoz
Copy link
Contributor

fsmunoz commented Sep 13, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2024
@katcosgrove
Copy link
Contributor

/approve

@katcosgrove
Copy link
Contributor

/assign @justaugustus

(I should be able to approve this myself, I'll go fix my own perms)

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, katcosgrove, satyampsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2388cc into kubernetes:main Sep 18, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants