WIP: Move staging repo away from gcr.io #7729
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
size/XS
jsafrane
reviewed
Jan 30, 2025
| @@ -18,10 +18,10 @@ set -o errexit | |||
| set -o nounset | |||
| set -o pipefail | |||
|
|
|||
| readonly repo="gcr.io/k8s-staging-sig-storage" | |||
| readonly repo="us-central1-docker.pkg.dev/k8s-staging-sig-storage" | |||
There was a problem hiding this comment.
This gives me 404 today (gcloud container images list-tags us-central1-docker.pkg.dev/k8s-staging-sig-storage/csi-attacher).
How can we confirm it's the right address?
There was a problem hiding this comment.
We have not pushed any images to the new staging repo yet, so I think you will get a 404 if you are looking specifically for csi-attacher images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated here https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr, gcr Container Registry will be shut down after March 18, 2025. We need to move our staging away from gcr.io.
Images on staging repo can be viewed here after we moved over (kubernetes-csi/csi-release-tools#271):
https://console.cloud.google.com/artifacts/docker/k8s-staging-sig-storage