Skip to content

Publish etcd 3.6.0-rc.4-0 image #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Publish etcd 3.6.0-rc.4-0 image #8038

wants to merge 1 commit into from
+1 −0

Conversation

joshjms
Copy link
Contributor

@joshjms joshjms commented Apr 27, 2025

@k8s-ci-robot k8s-ci-robot requested review from ahrtr and bzsuni April 27, 2025 15:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @joshjms. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 27, 2025
@serathius
Copy link
Contributor

Please link to CI run that builds the image.

@joshjms
Copy link
Contributor Author

joshjms commented Apr 27, 2025

@serathius sha256 digest is from https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/post-kubernetes-push-image-etcd/1916473262649380864#1:build-log.txt%3A1

@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2025
@serathius
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2025
@serathius
Copy link
Contributor

/assign @saschagrunert

@ahrtr
Copy link
Member

ahrtr commented Apr 27, 2025

/lgtm

Thanks @joshjms

cc @dims

@ahrtr ahrtr mentioned this pull request Apr 27, 2025
Open
@dims
Copy link
Member

dims commented Apr 27, 2025

/approve
/lgtm

@pacoxu

This comment was marked as duplicate.

Sign in to view
@ahrtr
Copy link
Member

ahrtr commented Apr 28, 2025

/approve

@ahrtr
Copy link
Member

ahrtr commented Apr 28, 2025

cc @BenTheElder

@ahrtr
Copy link
Member

ahrtr commented Apr 28, 2025

cc @palnabarun

@humblec
Copy link
Contributor

humblec commented Apr 28, 2025

/lgtm

@humblec
Copy link
Contributor

humblec commented Apr 28, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, dims, humblec, joshjms, serathius
Once this PR has been reviewed and has the lgtm label, please ask for approval from saschagrunert. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Contributor

@kubernetes/release-engineering

@serathius
Copy link
Contributor

Owners

k8s.io/OWNERS_ALIASES

Lines 232 to 240 in c33a4ba

release-engineering-approvers:
- cpanato # subproject owner / Release Manager / SIG Technical Lead
- jeremyrickard # subproject owner / Release Manager / SIG Chair
- justaugustus # subproject owner / Release Manager / SIG Chair
- palnabarun # Release Manager
- puerco # subproject owner / Release Manager / SIG Technical Lead
- saschagrunert # subproject owner / Release Manager / SIG Chair
- Verolop # subproject owner / Release Manager / SIG Technical Lead
- xmudrii # Release Manager

@serathius
Copy link
Contributor

@joshjms can you send a PR to add sig-etcd-leads to approvers in https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/images/k8s-staging-etcd/OWNERS ?

@serathius
Copy link
Contributor

ping @cpanato @justaugustus @palnabarun @puerco @saschagrunert @Verolop @xmudrii

@joshjms
Copy link
Contributor Author

joshjms commented Apr 28, 2025

#8046 done @serathius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr Awaiting requested review from ahrtr

@bzsuni bzsuni Awaiting requested review from bzsuni

Assignees

@dims dims

@saschagrunert saschagrunert

@humblec humblec

@serathius serathius

@ahrtr ahrtr

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joshjms @k8s-ci-robot @serathius @ahrtr @dims @pacoxu @humblec @saschagrunert