-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Specify required fixed MaxSurge and MaxUnavailable on MIGs #17470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Specify required fixed MaxSurge and MaxUnavailable on MIGs #17470
Conversation
Hi @flopib. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
72a7f6f
to
f42e52b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f42e52b
to
e0e51f2
Compare
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
When passing
UpdatePolicy
objects to GCP API, values formax_surge
andmax_unavailable
are also expected.According to the REST API documentation, those values default to the amount of zones in which the instance group operates. As kops uses zonal instance groups, that value must be set to 1.