scalability: support PRE_TEST_CMD environment variable - #18625
Conversation
kubernetes-prow
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
cncf-cla: yes
|
Hi @YahiaBadr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes-prow
Bot
removed
the
do-not-merge/work-in-progress
| KUBETEST2_ARGS+=("--admin-access=${ADMIN_ACCESS:-}") | ||
| KUBETEST2_ARGS+=("--env=KOPS_FEATURE_FLAGS=${KOPS_FEATURE_FLAGS}") | ||
| KUBETEST2_ARGS+=("--pre-test-cmd=${REPO_ROOT}/tests/e2e/scenarios/scalability/pre-test.sh") | ||
| KUBETEST2_ARGS+=("--pre-test-cmd=${PRE_TEST_CMD:-${REPO_ROOT}/tests/e2e/scenarios/scalability/pre-test.sh}") |
There was a problem hiding this comment.
What's the purpose of it? I don't think we want to complicate scalability tests
There was a problem hiding this comment.
it is an opt-in option, that allows running a custom script instead of the default one.
There was a problem hiding this comment.
Optional things are not without cost. I don't want us to support arbitrary everything.
There was a problem hiding this comment.
So, what is your suggestion as we need to run a controller pod before the test starts, is there a current option that we can use?
There was a problem hiding this comment.
Start from filing issue why and how you want to extend scalability tests? Don't send random PR without description.
YahiaBadr
changed the title
2 participants
This PR allows running a custom pre-test script, by passing the path through the env variable PRE_TEST_CMD.
If not passed, the default pre-script will run
{REPO_ROOT}/tests/e2e/scenarios/scalability/pre-test.sh}