config.go: invoke the MaskProxyPasswordWithKey function to hide the e… #20222
Conversation
…nvironment variable When the HTTP_PROXY variable is set in the environment, Minikube hides the password when showing the network options, but displays it when showing the (env) variable. The "showVersionInfo" function has been changed to hide the variable's password as well.
The committers listed above are authorized under a signed CLA. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @CalobTech! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @CalobTech. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
size/XS
There was a problem hiding this comment.
thank you @CalobTech for this PR, do you mind pasting the output of minikube Before/After this PR
(ofc with dummy value for the password)
Before $ ./minikube-linux-amd64-orig start After $ ./minikube-linux-amd64-patch start |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
There was a problem hiding this comment.
sorry @CalobTech for the wait plz take another look and we can merge this, plz also run "make lint" and fix the lint issues
https://github.com/kubernetes/minikube/actions/runs/12679507131/job/35392136574?pr=20222
| @@ -49,6 +49,7 @@ func showVersionInfo(k8sVersion string, cr cruntime.Manager) { | |||
| out.Infof("opt {{.docker_option}}", out.V{"docker_option": v}) | |||
| } | |||
| for _, v := range config.DockerEnv { | |||
| v = util.MaskProxyPasswordWithKey(v) | |||
There was a problem hiding this comment.
sorry for the long wait on reviewing this PR,
do you mind moving tihs function to the proxy package ?
proxy.MaskProxyPasswordWithKey
there are two Proxy related functions in the util package and need to be moved to proxy package
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CalobTech The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nvironment variable
When the HTTP_PROXY variable is set in the environment, Minikube hides the password when showing the network options, but displays it when showing the (env) variable.
The "showVersionInfo" function has been changed to hide the variable's password as well.