Skip to content

Add TODO about fixing pod-startup-time phases #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022
+5 −0
Merged

Add TODO about fixing pod-startup-time phases #2007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions clusterloader2/pkg/measurement/common/slos/pod_startup_latency.go
View file
Original file line number Diff line number Diff line change
@@ -265,6 +265,11 @@ func (p *podStartupLatencyMeasurement) gather(c clientset.Interface, identifier
return summaries, err
}

// TODO(#2006): gatherScheduleTimes is currently listing events at the end of the test.
// Given that events by default have 1h TTL, for measurements across longer periods
// it just returns incomplete results.
// Given that we don't 100% accuracy, we should switch to a mechanism that is similar
// to the one that slo-monitor is using (added in #1477).
func (p *podStartupLatencyMeasurement) gatherScheduleTimes(c clientset.Interface) error {
selector := fields.Set{
"involvedObject.kind": "Pod",