Skip to content

Add go 1.23 cross variants for 1.29 and 1.30 #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+18 −0
Closed

Add go 1.23 cross variants for 1.29 and 1.30 #3926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions images/build/cross/variants.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ variants:
GO_MAJOR_VERSION: '1.22'
OS_CODENAME: 'bullseye'
REVISION: '0'
v1.30-go1.23-bullseye:
CONFIG: 'go1.23-bullseye'
TYPE: 'default'
IMAGE_VERSION: 'v1.30.0-go1.23.6-bullseye.0'
KUBERNETES_VERSION: 'v1.30.0'
GO_VERSION: '1.23.6'
GO_MAJOR_VERSION: '1.23'
OS_CODENAME: 'bullseye'
REVISION: '0'
v1.30-go1.22-bullseye:
CONFIG: 'go1.22-bullseye'
TYPE: 'default'
Expand All @@ -53,6 +62,15 @@ variants:
GO_MAJOR_VERSION: '1.22'
OS_CODENAME: 'bullseye'
REVISION: '0'
v1.29-go1.23-bullseye:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we plan on releasing any more 1.29 patches, so we can likely remove these. I don't think it will hurt anything and potentially might be useful for downstream folks?

@kubernetes/release-managers, we have marked 1.29 as EOL now right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep we can drop that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt there a few other things to build before we reach here, we need to follow #3914 as example, i can do that.

let me know

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seemed like that already built the 1.23.6 bits for go runner, etc. I thought this was just filling in the last missing bits for 1.29/1.30

happy to close this in favor of a more correct sequence if you want to take over

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do, will start today soon

CONFIG: 'go1.23-bullseye'
TYPE: 'default'
IMAGE_VERSION: 'v1.29.0-go1.23.6-bullseye.0'
KUBERNETES_VERSION: 'v1.29.0'
GO_VERSION: '1.23.6'
GO_MAJOR_VERSION: '1.23'
OS_CODENAME: 'bullseye'
REVISION: '0'
v1.29-go1.22-bullseye:
CONFIG: 'go1.22-bullseye'
TYPE: 'default'
Expand Down
Loading