Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release notes text in map files #2096

Merged

Conversation

ramrodo
Copy link
Member

@ramrodo ramrodo commented Nov 23, 2022

This PR adds single quotes and a pipe break line in the text field since the krel tool is throwing an error at trying to create release notes for v1.26.0-rc.0:

FATA creating Draft PR:
while running release notes fix flow: while getting map for PR #109189:
while reading release notes maps: while parsing note map in
/tmp/k8s-3532398094/releases/release-1.26/release-notes/maps/pr-86139-map.yaml:
decoding note map: yaml: line 5: could not find expected ':'

This issue is already reported at kubernetes/release#2753

What type of PR is this:

/kind cleanup

What this PR does / why we need it:

This PR is needed for creating release notes for v1.26.0-rc.0

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramrodo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/release-team Issues or PRs related to the release-team subproject label Nov 23, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2022
@ramrodo
Copy link
Member Author

ramrodo commented Nov 23, 2022

/cc @kubernetes/release-team-release-notes

@sayantani11
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 56d4394 into kubernetes:master Nov 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 23, 2022
@ramrodo ramrodo deleted the fix-release-notes-test-in-maps branch November 23, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants