Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create 1.33 release directory #2706

Merged
merged 10 commits into from
Jan 18, 2025
Merged

Create 1.33 release directory #2706

merged 10 commits into from
Jan 18, 2025

Conversation

npolshakova
Copy link
Contributor

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Creates the 1.33 release directory as per #2705

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 23, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2024
@npolshakova npolshakova mentioned this pull request Dec 23, 2024
Open
@npolshakova npolshakova marked this pull request as ready for review December 30, 2024 17:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
Vyom-Yadav
Vyom-Yadav requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on board observation and column naming:

fsmunoz
fsmunoz reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@fsmunoz fsmunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments tied with the v1.32 experience.

npolshakova
npolshakova commented Jan 16, 2025
View reviewed changes
releases/release-1.33/README.md
| Deprecations and Removals blog published | Comms | Monday 24th March 2025 | week 11 | |
| **Preparing for Feature blogs review — Initiating outreach** | Comms | Monday 24th March 2025 | week 11 | |
| Docs deadline — PRs ready for review | Docs Lead | Tuesday 25th March 2025 | week 11 | |
| Release Highlights deadline | Comms | Tuesday 25th March 2025 | week 11 | |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbianchidev @rytswd Updated the Release Highlights deadline to be before Release blog ready to review based on https://kubernetes.slack.com/archives/C2C40FMNF/p1736496690555129?thread_ts=1735581655.943799&cid=C2C40FMNF. Let me know how this looks like from the Comms perspective.

@npolshakova npolshakova requested a review from gracenng January 17, 2025 19:49
gracenng
gracenng approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@gracenng gracenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

could you please a timezone link for our major deadline in a following PR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@katcosgrove
Copy link
Contributor

@Vyom-Yadav could you please remove your change request?

@Vyom-Yadav
Copy link
Member

@Vyom-Yadav could you please remove your change request?

Does that prevent a PR from merging? I thought prow did it irrespective of whether a 'requested changes' is pending.

@npolshakova
Copy link
Contributor Author

I think this needs an approval from someone in @kubernetes/sig-release-leads to merge

@katcosgrove
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gracenng, katcosgrove, npolshakova, Vyom-Yadav
Once this PR has been reviewed and has the lgtm label, please assign jeremyrickard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@katcosgrove
Copy link
Contributor

Dang, though I had the perms for this.

/assign @jeremyrickard

@npolshakova npolshakova merged commit 20669ca into kubernetes:master Jan 18, 2025
1 of 2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsmunoz fsmunoz fsmunoz left review comments

@soltysh soltysh soltysh left review comments

@pacoxu pacoxu pacoxu left review comments

@thockin thockin thockin left review comments

@chanieljdan chanieljdan chanieljdan left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@wendy-ha18 wendy-ha18 wendy-ha18 left review comments

@gracenng gracenng gracenng approved these changes

@Vyom-Yadav Vyom-Yadav Vyom-Yadav approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@Verolop Verolop Awaiting requested review from Verolop

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@jeremyrickard jeremyrickard

@gracenng gracenng

@Vyom-Yadav Vyom-Yadav

Labels
area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.