Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clusterloader2 provider to azure #33500

Closed
wants to merge 1 commit into from
Closed

Update clusterloader2 provider to azure #33500

wants to merge 1 commit into from

Conversation

mboersma
Copy link
Contributor

Changes the cluster-loader2 command-line flag to --provider=azure (from --provider=aks) to match the perf-tests PR that renames it: kubernetes/perf-tests#2864

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2024
@mboersma
Copy link
Contributor Author

/hold until the perf-tests PR merges
/cc @Jont828 @jackfrancis

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2024
jackfrancis
jackfrancis approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jackfrancis, mboersma
Once this PR has been reviewed and has the lgtm label, please assign claudiubelu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Contributor

/assign @jsturtevant @marosset

@jsturtevant
Copy link
Contributor

we plan to drop these jobs: #33395

@mboersma
Copy link
Contributor Author

/close

Nothing to do, since #33395 was merged.

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

Nothing to do, since #33395 was merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma mboersma deleted the perf-tests-provider-azure branch September 19, 2024 21:01
@jackfrancis
Copy link
Contributor

thx @mboersma and @jsturtevant!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@jsturtevant jsturtevant

@jackfrancis jackfrancis

@marosset marosset

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mboersma @k8s-ci-robot @jackfrancis @jsturtevant @marosset