Skip to content

Conversation

@HirazawaUi
Copy link
Contributor

@HirazawaUi HirazawaUi commented Nov 5, 2025

The EventedPLEG does not support containerd 1.7, so we don't need to test it, we only need to test Ubuntu. If we test containerd 1.7 simultaneously, the test job will fail, so we need to add an image configuration file that only uses Ubuntu for it.

Sorry for submit the PR once more. I'm not very familiar with the k8s testing mechanism and only realized this file needed modification after encountering the error.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs labels Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Nov 5, 2025
@HirazawaUi
Copy link
Contributor Author

/assign @SergeyKanzhelev

@mariafromano-25
Copy link
Contributor

/assign @haircommander

@mariafromano-25 mariafromano-25 moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Nov 19, 2025
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2025
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

holding to add a comment into image config file.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@HirazawaUi HirazawaUi force-pushed the add-image-config-file-pleg branch from 8a19492 to 0f66375 Compare November 20, 2025 11:33
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@haircommander
Copy link
Contributor

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6951635 into kubernetes:master Nov 20, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from PRs - Needs Reviewer to Done in SIG Node CI/Test Board Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

@HirazawaUi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

The EventedPLEG does not support containerd 1.7, so we don't need to test it, we only need to test Ubuntu. If we test containerd 1.7 simultaneously, the test job will fail, so we need to add an image configuration file that only uses Ubuntu for it.

Sorry for submit the PR once more. I'm not very familiar with the k8s testing mechanism and only realized this file needed modification after encountering the error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

5 participants