Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to automatically update schedule.yaml #45762

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add workflow to automatically update schedule.yaml #45762

merged 1 commit into from
Aug 16, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 3, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot requested a review from salaxander April 3, 2024 12:38
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tengqm April 3, 2024 12:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2024
@saschagrunert saschagrunert force-pushed the update-schedule-yaml branch from bbddca3 to d85cfec Compare April 3, 2024 12:44
@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a63678a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6639d6e30974770008a2540e
😎 Deploy Preview https://deploy-preview-45762--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saschagrunert saschagrunert force-pushed the update-schedule-yaml branch 2 times, most recently from ce084d6 to 02cc2be Compare April 3, 2024 13:17
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 3, 2024
@saschagrunert saschagrunert force-pushed the update-schedule-yaml branch from 3f26596 to 565f42a Compare April 3, 2024 15:01
sftim
sftim reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

/hold

We're overall wary of having workflows write to GitHub (we'd typically use Prow, but GitHub Actions has gained lots of feature since Prow came into existence).

Let's check that the SIG is happy with this and is confident we can maintain it.

.github/workflows/update-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/update-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/update-schedule.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024
@sftim sftim mentioned this pull request Apr 3, 2024
Merged
@sftim
Copy link
Contributor

sftim commented Apr 3, 2024

I wonder if we should address #38431 - Split “can approve English content changes” from “can review general website changes” permissions - first.

@saschagrunert
Copy link
Member Author

I'd like to highlight that the new schedule-builder does not handle data/releases/eol.yaml nor updates the "Upcoming Monthly Releases" table. I think we can follow-up on that.

@saschagrunert saschagrunert force-pushed the update-schedule-yaml branch from 565f42a to 1ae460b Compare April 3, 2024 15:22
@saschagrunert saschagrunert force-pushed the update-schedule-yaml branch 7 times, most recently from 02cf82c to a91b3c7 Compare April 4, 2024 08:44
xmudrii
xmudrii reviewed Apr 4, 2024
View reviewed changes
.github/workflows/update-schedule.yml Outdated Show resolved Hide resolved
data/releases/schedule.yaml Outdated Show resolved Hide resolved
data/releases/schedule.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
xmudrii
xmudrii approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@saschagrunert
Copy link
Member Author

@kubernetes/sig-docs-leads are we okay to move forward with this?

@cpanato
Copy link
Member

cpanato commented May 6, 2024

/lgtm

@sftim
Copy link
Contributor

sftim commented May 6, 2024

For LGTM on this particular change, let's get it from a SIG tech lead (or a chair acting in their stead). Leaving the existing hold in place.

Noting LGTMs from #45762 (comment) and other reviews.

As an emeritus tech lead:
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot k8s-ci-robot requested a review from xmudrii May 6, 2024 21:41
sftim
sftim reviewed May 6, 2024
View reviewed changes
.github/workflows/update-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/update-schedule.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any CLA issues expected with this workflow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we're using the same approach there for example: kubernetes-sigs/downloadkubernetes#630

@saschagrunert saschagrunert force-pushed the update-schedule-yaml branch from 89df646 to a63678a Compare May 7, 2024 07:23
@sftim
Copy link
Contributor

sftim commented Aug 2, 2024

/retitle Add workflow to automatically update schedule.yaml

@k8s-ci-robot k8s-ci-robot changed the title Add workflow to automatically update schedule.yaml Add workflow to automatically update schedule.yaml Aug 2, 2024
@tengqm
Copy link
Contributor

tengqm commented Aug 5, 2024

/approve
Let's try it and see if it works as expected.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@sftim
Copy link
Contributor

sftim commented Aug 5, 2024

@tengqm should we also unhold the PR?

xmudrii
xmudrii approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 079128f4d58dc10007985c4dcebe5b7d37518b15

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, tengqm, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii mentioned this pull request Aug 15, 2024
Merged
@xmudrii
Copy link
Member

xmudrii commented Aug 15, 2024

@tengqm Can we unhold and proceed with this PR? We had patch releases yesterday and this is a great opportunity to test this automation. :)

@tengqm
Copy link
Contributor

tengqm commented Aug 16, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5fcc6d8 into kubernetes:main Aug 16, 2024
6 checks passed
@saschagrunert saschagrunert deleted the update-schedule-yaml branch August 16, 2024 06:34
@saschagrunert saschagrunert mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@xmudrii xmudrii xmudrii approved these changes

@salaxander salaxander Awaiting requested review from salaxander

@tengqm tengqm Awaiting requested review from tengqm

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@cpanato cpanato

@xmudrii xmudrii

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate updating patch releases calendar on the Kubernetes website
6 participants
@saschagrunert @sftim @cpanato @k8s-ci-robot @tengqm @xmudrii