-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Translated content/en/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control into Japanese #47499
[ja] Translated content/en/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control into Japanese #47499
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
eb3c07e
to
36a3498
Compare
/hold Once #47497 merged, feel free to unhold |
/cc @rihib |
@Okabe-Junya: GitHub didn't allow me to request PR reviews from the following users: rihib. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0f0faf9
to
eda2ac4
Compare
…mentalGroups-control into Japanese
eda2ac4
to
ba4ee15
Compare
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
``` | ||
|
||
{{<note>}} | ||
`status.containerStatuses[].user.linux`フィールドで公開されているユーザー、グループ情報は、コンテナの最初のプロセスに、_最初に付与された_ 情報であることに注意してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「最初に付与された」の後に半角スペースが入っています
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
斜体(
_ここが斜体になります_
)のレンダリングの都合上、スペースが必要なので、この方がベターです🙆♂️
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
@everpeace レビューさせていただきましたのでご確認いただけますと幸いです🙇 @Okabe-Junya 下記を参考にしても判断がつきかねたものについてはご質問させていただきました🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビューありがとうございます!
自分宛にメンション飛んできている箇所に返信しておきました
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Show resolved
Hide resolved
``` | ||
|
||
{{<note>}} | ||
`status.containerStatuses[].user.linux`フィールドで公開されているユーザー、グループ情報は、コンテナの最初のプロセスに、_最初に付与された_ 情報であることに注意してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
斜体(
_ここが斜体になります_
)のレンダリングの都合上、スペースが必要なので、この方がベターです🙆♂️
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Junya Okabe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rihib @Okabe-Junya レビューありがとうございました。ほとんどの提案に対応いたしました。また、いくつかのご指摘に対してはコメントさせていただいています。再レビューをお願いいたします 🙇
…upplementalGroups-control/index.md
- [Podとコンテナにセキュリティコンテキストを設定する](/ja/docs/tasks/configure-pod-container/security-context/)(`supplementalGroupsPolicy`の詳細) | ||
- [KEP-3619: Fine-grained SupplementalGroups control](https://github.com/kubernetes/enhancements/issues/3619) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minituesな変更ですみません。KEPのリンク自体をblogに含めるのを失念していました。英語版の方も並行で修正をかけており、同等の変更です。
@everpeace ご対応いただきましてありがとうございます。自分はLGTMです!🙇 @Okabe-Junya ご確認ありがとうございます!🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!
rihib-sanの代わりにLGTMを打ちます
/lgtm
approverとして確認してLGTMだったので
/approve
/label tide/merge-method-squash
LGTM label has been added. Git tree hash: cd25f419a7e21a83e03bb28a840825ebe57a877c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Okabe-Junya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
upstream (en)側との兼ね合いがあると思うので、お好きなタイミングでマージ - unholdしてください。 |
(すみません、hold間に合ってなさそうだったのでfixある場合は別途PRあげてください) |
/unhold |
…mentalGroups-control into Japanese (kubernetes#47499) * [ja] translated content/en/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control into Japanese * Apply suggestions from code review Co-authored-by: Junya Okabe <[email protected]> * [ja] add kep link to content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md --------- Co-authored-by: Junya Okabe <[email protected]>
Depends on:
Description
Issue
Closes: #47498
Preview Page: https://deploy-preview-47499--kubernetes-io-main-staging.netlify.app/ja/blog/2024/08/22/fine-grained-supplementalgroups-control/