Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Translated content/en/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control into Japanese #47499

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Aug 14, 2024

Depends on:


Description

  • Translated content/en/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control into Japanese

Issue

Closes: #47498

Preview Page: https://deploy-preview-47499--kubernetes-io-main-staging.netlify.app/ja/blog/2024/08/22/fine-grained-supplementalgroups-control/

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/localization General issues or PRs related to localization labels Aug 14, 2024
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 14, 2024
Copy link

netlify bot commented Aug 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a44c78e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66bff20aa3936400085adaa0
😎 Deploy Preview https://deploy-preview-47499--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@everpeace everpeace force-pushed the translate-kep-3619-blog branch 2 times, most recently from eb3c07e to 36a3498 Compare August 14, 2024 13:17
@everpeace everpeace marked this pull request as ready for review August 14, 2024 13:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kakts August 14, 2024 13:27
@Okabe-Junya
Copy link
Member

/hold

Once #47497 merged, feel free to unhold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2024
@Okabe-Junya
Copy link
Member

/cc @rihib

@k8s-ci-robot
Copy link
Contributor

@Okabe-Junya: GitHub didn't allow me to request PR reviews from the following users: rihib.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rihib

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@everpeace everpeace force-pushed the translate-kep-3619-blog branch 3 times, most recently from 0f0faf9 to eda2ac4 Compare August 15, 2024 04:14
@everpeace everpeace force-pushed the translate-kep-3619-blog branch from eda2ac4 to ba4ee15 Compare August 16, 2024 02:31
@everpeace
Copy link
Contributor Author

/unhold

@rihib I rebased this to the latest main because #47497 was merged. PTAL 🙇

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
```

{{<note>}}
`status.containerStatuses[].user.linux`フィールドで公開されているユーザー、グループ情報は、コンテナの最初のプロセスに、_最初に付与された_ 情報であることに注意してください。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最初に付与された」の後に半角スペースが入っています

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

斜体(_ここが斜体になります_)のレンダリングの都合上、スペースが必要なので、この方がベターです🙆‍♂️

@rihib
Copy link
Contributor

rihib commented Aug 16, 2024

@everpeace レビューさせていただきましたのでご確認いただけますと幸いです🙇

@Okabe-Junya 下記を参考にしても判断がつきかねたものについてはご質問させていただきました🙏
https://kubernetes.io/ja/docs/contribute/localization/

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューありがとうございます!

自分宛にメンション飛んできている箇所に返信しておきました

```

{{<note>}}
`status.containerStatuses[].user.linux`フィールドで公開されているユーザー、グループ情報は、コンテナの最初のプロセスに、_最初に付与された_ 情報であることに注意してください。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

斜体(_ここが斜体になります_)のレンダリングの都合上、スペースが必要なので、この方がベターです🙆‍♂️

Copy link
Contributor Author

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rihib @Okabe-Junya レビューありがとうございました。ほとんどの提案に対応いたしました。また、いくつかのご指摘に対してはコメントさせていただいています。再レビューをお願いいたします 🙇

Comment on lines +156 to +157
- [Podとコンテナにセキュリティコンテキストを設定する](/ja/docs/tasks/configure-pod-container/security-context/)(`supplementalGroupsPolicy`の詳細)
- [KEP-3619: Fine-grained SupplementalGroups control](https://github.com/kubernetes/enhancements/issues/3619)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minituesな変更ですみません。KEPのリンク自体をblogに含めるのを失念していました。英語版の方も並行で修正をかけており、同等の変更です。

#47529

@rihib
Copy link
Contributor

rihib commented Aug 17, 2024

@everpeace ご対応いただきましてありがとうございます。自分はLGTMです!🙇

@Okabe-Junya ご確認ありがとうございます!🙏

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

rihib-sanの代わりにLGTMを打ちます
/lgtm

approverとして確認してLGTMだったので
/approve

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 17, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cd25f419a7e21a83e03bb28a840825ebe57a877c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2024
@Okabe-Junya
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2024
@Okabe-Junya
Copy link
Member

Okabe-Junya commented Aug 17, 2024

@everpeace

upstream (en)側との兼ね合いがあると思うので、お好きなタイミングでマージ - unholdしてください。

@k8s-ci-robot k8s-ci-robot merged commit f04b70c into kubernetes:main Aug 17, 2024
6 checks passed
@Okabe-Junya
Copy link
Member

(すみません、hold間に合ってなさそうだったのでfixある場合は別途PRあげてください)

@Okabe-Junya
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2024
jimangel pushed a commit to jimangel/website that referenced this pull request Oct 30, 2024
…mentalGroups-control into Japanese (kubernetes#47499)

* [ja] translated content/en/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control into Japanese

* Apply suggestions from code review

Co-authored-by: Junya Okabe <[email protected]>

* [ja] add kep link to content/ja/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control/index.md

---------

Co-authored-by: Junya Okabe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Translate content/en/blog/_posts/2024-08-22-Fine-grained-SupplementalGroups-control into Japanese
4 participants