Skip to content

Fix gate status for ComponentSLIs in 1.32 #49340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Fix gate status for ComponentSLIs in 1.32 #49340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...t/en/docs/reference/command-line-tools-reference/feature-gates/ComponentSLIs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ stages:
- stage: beta
defaultValue: true
fromVersion: "1.27"
toVersion: "1.31"
- stage: stable
locked: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK, but maybe slightly misleading; we don't support a locked key in anything I know of.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locked is gonna be important, because a feature which has lockedToDefault: true will not be shown from the help message such as kube-apiserver --help.
The gate is there, not removed. You cannot change its setting. A weird state it is.
We will need to revise the shortcode someday to reflect this.
Adding locked: true is a first step. At least, it is doing no harm at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: file a frozen issue about that improvement around locked. Then we've something to refer back to, and if we close the issue we'll know we ought to do cleanup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed one: #49388

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
locked: true

as #49388 isn't implemented yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it hurt?
Do you mean we revisit this features again to find if they are locked or not later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a cost here; people might see this field and infer it's implemented. Finding out that it's not can be a surprise, replicated across multiple contributors.

I can see a small chance of a painful surprise, where maybe someone relies on this value and they shouldn't have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not about you think. People read the rendered HTML, not the YAML.
I'm all for removing this information if you sign up to add this back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted; I still have the qualm I had before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tengqm would you be willing to start a Slack discussion about the way forward?

default: true
fromVersion: "1.32"

---
Enable the `/metrics/slis` endpoint on Kubernetes components like
kubelet, kube-scheduler, kube-proxy, kube-controller-manager, cloud-controller-manager
Expand Down