Skip to content

KEP-4193: 1.33 updates for ServiceAccountTokenNodeBinding GA #49413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

KEP-4193: 1.33 updates for ServiceAccountTokenNodeBinding GA #49413

merged 1 commit into from
Apr 5, 2025

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 13, 2025

Description

Doc updates for KEP-4193 GA

Issue

xref kubernetes/enhancements#4193

/sig auth
/assign @munnerz

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. language/en Issues or PRs related to English language labels Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2025
@liggitt liggitt mentioned this pull request Jan 13, 2025
Closed
25 tasks
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 1eae769
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67dc756ad24bbd0009e08250

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1eae769
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67dc756af15e8a0008eeb843
😎 Deploy Preview https://deploy-preview-49413--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@munnerz
Copy link
Member

munnerz commented Jan 13, 2025

This LGTM, but we also should update https://github.com/kubernetes/website/blob/dev-1.33/content/en/docs/reference/access-authn-authz/service-accounts-admin.md#bound-service-account-tokens to indicate that binding to Node objects is GA as of v1.33 too.

munnerz
munnerz approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@munnerz munnerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 063f9ea71594492ec6e7992f3f6885acb487158f

sftim
sftim reviewed Jan 13, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot requested a review from munnerz January 13, 2025 17:28
@enj
Copy link
Member

enj commented Jan 14, 2025

LGTM as well.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2025
@hacktivist123
Copy link
Contributor

Hello @liggitt 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2025
@liggitt
Copy link
Member Author

liggitt commented Mar 20, 2025

rebased

@liggitt
Copy link
Member Author

liggitt commented Mar 20, 2025

this is already reviewed and ready for doc approval

@hacktivist123
Copy link
Contributor

Thanks @liggitt

@rayandas
Copy link
Member

rayandas commented Apr 4, 2025

This PR could use a Doc approval @kubernetes/sig-docs-leads Thanks!

@tengqm
Copy link
Contributor

tengqm commented Apr 5, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53248e8cb6f9345b6ce76b4292c575e25b95c950

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 67503b6 into kubernetes:dev-1.33 Apr 5, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@sftim sftim sftim left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@munnerz munnerz

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@liggitt @munnerz @k8s-ci-robot @enj @hacktivist123 @rayandas @tengqm @sftim