Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a sha256 checking bug when downloading different versions of binary files #1646

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

24sama
Copy link
Collaborator

@24sama 24sama commented Dec 7, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: a sha256 checking bug when downloading different versions of binary files.
Now, the binaries will download into the subdirectory, which is the directory tree as:

xxxx/kubeadm/v1.24.8/amd64/kubeadm
xxxx/kubeadm/v1.24.8/arm64/kubeadm
xxxx/kubeadm/v1.25.0/amd64/kubeadm

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 7, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2022
@pixiake
Copy link
Collaborator

pixiake commented Dec 7, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3b989912c817f4fb8d62d04ed59b783dce17eeac

@ks-ci-bot ks-ci-bot merged commit fab5588 into kubesphere:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants